442067 - "Page Bookmarked" dialog displays previous information upon clicking "Bookmark this tab"

Status: VERIFIED DUPLICATE of bug 441326

(Firefox :: Bookmarks & History, defect)

Description

[Brandon Arnold]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0

Assume that another tab has been previously bookmarked in the current Firefox session.  Bookmarking another tab by right-clicking on it and choosing "Bookmark this tab" from the pop-up menu will result in incorrect information being displayed in the "Edit this Bookmark" dialog.

Reproducible: Always

Steps to Reproduce:
1. Open 2 tabs loaded with two different sites.
2. Right-click the first site's tab and choose "Bookmark this tab".
3. If the dialog doesn't say "Edit this Bookmark" at the top, click the "Cancel" button and start over.  If it does, set info accordingly, and click the "Done" button.
4. Right-click the second site's tab and choose "Bookmark this tab".
Actual Results:  
The "Edit this Bookmark" dialog will show the info from the previously bookmarked tab.  Nonetheless, clicking the "Done" button with the old information on it will result in the correct information (the second tab's title, URL information, etc.) being saved to the default spot instead of what is displayed.

Expected Results:  
The "Edit this Bookmark" dialog should show the second tab's title, URL information, etc. instead of that from the previous tab.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

What do you mean with "start over"? If you want to bookmark a new URL the dialog will always show "Page Bookmarked". Please be more specific. Personally I cannot see such an issue with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.1pre) Gecko/2008062505 GranParadiso/3.0.1pre ID:2008062505

Comment 3

[Brandon Arnold]

There are two different dialog boxes that can appear, depending on whether or not the site is already in your bookmarks.  If the site is already in your bookmarks, the dialog box's title will be "Edit this Bookmark", and you can change the title and location of the bookmark that you already have.  If it is not already in your bookmarks, you will get a "Page Bookmarked" dialog that is larger and has several more textboxes.  What seems to be happening is Firefox isn't correctly changing between the two in some situations.

Here are more explicit steps to reproduce the bug.  I use the sites "www.brandon.com" and "www.arnold.com" to assure that they wouldn't already be in your bookmarks, which is important for this to work correctly.

1.) Open a new session of Firefox, do not use the session you're currently in.
2.) In the address bar, type in www.brandon.com and press enter.
3.) Add a new tab.
4.) In the address bar, type in www.arnold.com and press enter.
5.) Right-click the first tab and click "Bookmark this tab"
6.) On the "Page Bookmarked" dialog, leave everything blank and click Done.
7.) Right-click the *FIRST* tab again, and click "Bookmark this tab"
8.) You will notice the "Edit this Bookmark" dialog will appear, because this is one that was already in your bookmarks--actually, if your system is slow enough, you'll see the "Page Bookmarked" dialog appear again and quickly change it's shape into a smaller dialog called "Edit this Bookmark".  Click Done or Cancel, makes no difference
9.) Now right-click the second tab and click "Bookmark this tab"

Notice that the title of the dialog that appears is "Page Bookmarked" even though it is the smaller dialog that was previously called "Edit this bookmark".  Also, the information is from the previously saved bookmark, and not this tab.

Comment 4

[Hasham]

Marking as dupe.

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv