Closed
Bug 442256
Opened 16 years ago
Closed 16 years ago
Make getURIs/IndicesForSelection easier to call from JS
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.1a1
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(1 file)
|
7.80 KB,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
Currently they use two out params because one is an array but we can make that one a retval to make the usage simpler.
|
Assignee | |
Comment 1•16 years ago
|
||
I had to reorder the parameters too, but that's just a simple tweak.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #327122 -
Flags: superreview?(bienvenu)
Attachment #327122 -
Flags: review?(bienvenu)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 327122 [details] [diff] [review]
Proposed patch
Ironically, these methods are never called from c++, which means we could simply drop the length out parameter, since the js callers never need it. GetIndicesForSelection won't be needed from c++ since those callers just use GetSelectedIndices, but I could imagine GetURIsForSelection might be used from c++.
Attachment #327122 -
Flags: superreview?(bienvenu)
Attachment #327122 -
Flags: superreview+
Attachment #327122 -
Flags: review?(bienvenu)
Attachment #327122 -
Flags: review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Target Milestone: --- → mozilla1.9.1a1
|
||
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•