442484 - packager.mk doesn't work correctly with non-default topsrcdir

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Robert Kaiser]

In http://hg.mozilla.org/users/kairo_kairo.at/index.cgi/calemaisu-test/file/f3a0dcddc05c/suite/locales/Makefile.in#l158 (same for installer and the mail pendents), we're calling toolkit's packager.mk so that we don't need separate copies of those toolkit files in our repository.

Because of this, http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/packager.mk#41 fails as the topsrcdir is not the mozilla-central directory in that case.

We can work around that pretty easily by using MOZILLA_DIR, which is set by rules.mk and can be set by our own rules.mk accordingly.

Comment 1

[Robert Kaiser]

Attachment: use MOZILLA_DIR instead of topsrcdir

This works fine with Firefox/Minefield from mozilla-central as well as SeaMonkey from the test repo.

Comment 2

[Robert Kaiser]

There's more that needs that change in packager.mk

Comment 3

[Robert Kaiser]

Attachment: use MOZILLA_DIR instead of topsrcdir - even more

Sorry for not having all this in the first patch, but I didn't actually doing a package before. With this patch, even creating a package works.

Comment 4

[Robert Kaiser]

fixed in changeset 8391ac1437ef