Closed Bug 442607 Opened 15 years ago Closed 12 years ago

Reminder details link does not work if calendar window is closed

Categories

(Calendar :: Alarms, defect)

Product:
Calendar
Component:
Alarms
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: tmatous, Assigned: Fallen)

Details

(Whiteboard: [not needed beta][no l10n impact])

Attachments

(1 file)

Fix - v1
2.62 KB, patch
bv1578
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.13pre) Gecko/20080331 Sunbird/0.8

In OSX, if the main calendar window is closed, clicking on the "Details" link from the Reminders window does nothing. Expected behavior is to open the calendar window and display the item associated with the alarm.

Reproducible: Always

Steps to Reproduce:
1.Open Sunbird
2.Close main window (with the X)
3.Click a Details link in Reminders window
Right, we should fix that... :-)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Confirmed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16pre) Gecko/2008062920 Calendar/0.9pre.

Error Console shows:

Error: calWindow has no properties
Source File: chrome://calendar/content/calendar-alarm-dialog.js
Line: 102
OS: Mac OS X → All
Hardware: Macintosh → All
Summary: Reminder details link does not work if calendar window is closed (OSX) → Reminder details link does not work if calendar window is closed
Flags: blocking-calendar1.0+
Whiteboard: [not needed beta][no l10n impact]
Attached patch Fix - v1 — — Splinter Review 
Assignee: nobody → philipp
Status: NEW → ASSIGNED

        Attachment #547958 -
        Flags: review?(bv1578)

    
    

    
  
This is rather edge case, but now it has a patch anyway. Removing from the 1.0 blocker list.
Flags: blocking-calendar1.0+
Whiteboard: [not needed beta][no l10n impact] → [not needed beta][no l10n impact][needs review]

    
    

    
  
Comment on attachment 547958 [details] [diff] [review]
Fix - v1

As far as I can see it works fine.

You could add a New Line at the end of the file calendar-alarm-dialog.js.

r+

        Attachment #547958 -
        Flags: review?(bv1578) → review+

    
    

    
  
(In reply to Decathlon from comment #5)
> You could add a New Line at the end of the file calendar-alarm-dialog.js.
Hm you mean it doesn't have an eol marker? I don't see that in the imported patch?
Whiteboard: [not needed beta][no l10n impact][needs review] → [not needed beta][no l10n impact]

    
    

    
  
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/9a65b6556462>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Trunk

    
    

    
  
This bug was also pushed to comm-beta and comm-aurora, likely during the last merge.
Target Milestone: Trunk → 1.0b6

          You need to log in
          before you can comment on or make changes to this bug.