Last Comment Bug 442618 - Eliminate dead function CERT_CertPackageType
: Eliminate dead function CERT_CertPackageType
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: 3.0
: All All
: P3 trivial (vote)
: 3.12.1
Assigned To: Julien Pierre
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-29 20:25 PDT by Nelson Bolyard (seldom reads bugmail)
Modified: 2008-07-21 13:10 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Remove dead function (3.62 KB, patch)
2008-07-18 12:01 PDT, Julien Pierre
nelson: review+
Details | Diff | Splinter Review

Description Nelson Bolyard (seldom reads bugmail) 2008-06-29 20:25:19 PDT
file nss/lib/pkcs7/certread.c contains a function CERT_CertPackageType
which is declared in public header cert.h.  

But according to mxr, that function is not exported in any .def file.
It is not used anywhere in NSS.  It is dead code.  Let's nuke it.
Comment 1 Julien Pierre 2008-07-18 12:01:45 PDT
Created attachment 330283 [details] [diff] [review]
Remove dead function
Comment 2 Nelson Bolyard (seldom reads bugmail) 2008-07-19 19:37:52 PDT
Comment on attachment 330283 [details] [diff] [review]
Remove dead function

This should do the job.
Comment 3 Julien Pierre 2008-07-21 13:10:04 PDT
Thanks, Nelson. I checked this in to the trunk.

Checking in certdb/cert.h;
/cvsroot/mozilla/security/nss/lib/certdb/cert.h,v  <--  cert.h
new revision: 1.73; previous revision: 1.72
done
Checking in pkcs7/certread.c;
/cvsroot/mozilla/security/nss/lib/pkcs7/certread.c,v  <--  certread.c
new revision: 1.13; previous revision: 1.12
done

Note You need to log in before you can comment on or make changes to this bug.