Closed Bug 442618 Opened 13 years ago Closed 13 years ago

Eliminate dead function CERT_CertPackageType

Categories

(NSS :: Libraries, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
3.12.1

People

(Reporter: nelson, Assigned: julien.pierre)

Details

Attachments

(1 file)

file nss/lib/pkcs7/certread.c contains a function CERT_CertPackageType
which is declared in public header cert.h.  

But according to mxr, that function is not exported in any .def file.
It is not used anywhere in NSS.  It is dead code.  Let's nuke it.
Assignee: nobody → julien.pierre.boogz
Priority: -- → P3
Target Milestone: --- → 3.12.1
Attachment #330283 - Flags: review?(nelson)
Comment on attachment 330283 [details] [diff] [review]
Remove dead function

This should do the job.
Attachment #330283 - Flags: review?(nelson) → review+
Thanks, Nelson. I checked this in to the trunk.

Checking in certdb/cert.h;
/cvsroot/mozilla/security/nss/lib/certdb/cert.h,v  <--  cert.h
new revision: 1.73; previous revision: 1.72
done
Checking in pkcs7/certread.c;
/cvsroot/mozilla/security/nss/lib/pkcs7/certread.c,v  <--  certread.c
new revision: 1.13; previous revision: 1.12
done
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.