Eliminate dead function CERT_CertPackageType

RESOLVED FIXED in 3.12.1

Status

NSS
Libraries
P3
trivial
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Nelson Bolyard (seldom reads bugmail), Assigned: Julien Pierre)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

3.62 KB, patch
Nelson Bolyard (seldom reads bugmail)
: review+
Details | Diff | Splinter Review
file nss/lib/pkcs7/certread.c contains a function CERT_CertPackageType
which is declared in public header cert.h.  

But according to mxr, that function is not exported in any .def file.
It is not used anywhere in NSS.  It is dead code.  Let's nuke it.
(Assignee)

Updated

9 years ago
Assignee: nobody → julien.pierre.boogz
Priority: -- → P3
Target Milestone: --- → 3.12.1
(Assignee)

Comment 1

9 years ago
Created attachment 330283 [details] [diff] [review]
Remove dead function
Attachment #330283 - Flags: review?(nelson)
Comment on attachment 330283 [details] [diff] [review]
Remove dead function

This should do the job.
Attachment #330283 - Flags: review?(nelson) → review+
(Assignee)

Comment 3

9 years ago
Thanks, Nelson. I checked this in to the trunk.

Checking in certdb/cert.h;
/cvsroot/mozilla/security/nss/lib/certdb/cert.h,v  <--  cert.h
new revision: 1.73; previous revision: 1.72
done
Checking in pkcs7/certread.c;
/cvsroot/mozilla/security/nss/lib/pkcs7/certread.c,v  <--  certread.c
new revision: 1.13; previous revision: 1.12
done
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.