Closed Bug 442714 Opened 13 years ago Closed 13 years ago

Mark nsAutoString as stack-only

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: benjamin, Assigned: benjamin)

Details

Attachments

(1 file, 1 obsolete file)

Mark nsAutoString as stack-only, rev. 1.1
3.97 KB, patch
dbaron
: review+
Details | Diff | Splinter Review 
AutoStrings should only appear on the stack. This makes it so. There are a couple uses I had to fix.
Attachment #327431 - Flags: review?(dbaron)
Does the nsCookieAttributes change do anything?  If so, what?

Looks like you eliminated a newline that you should have left in nsPrefBranch.h.
the cookie constructor was when stack classes had to have a constructor to be analyzed correctly. That's no longer the case, so I removed it. Also updated the newline, added context, and made the annotation style match the agreed formatting from the m.d.platform thread.
Attachment #327431 - Attachment is obsolete: true
Attachment #327433 - Flags: review?(dbaron)
Attachment #327431 - Flags: review?(dbaron)
Comment on attachment 327433 [details] [diff] [review]
Mark nsAutoString as stack-only, rev. 1.1

r=dbaron
Attachment #327433 - Flags: review?(dbaron) → review+
Pushed to mozilla-central, revision 2a894be5a1b6
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.