Status

()

defect
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: benjamin, Assigned: benjamin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

11 years ago
AutoStrings should only appear on the stack. This makes it so. There are a couple uses I had to fix.
Attachment #327431 - Flags: review?(dbaron)
Does the nsCookieAttributes change do anything?  If so, what?

Looks like you eliminated a newline that you should have left in nsPrefBranch.h.
Assignee

Comment 2

11 years ago
the cookie constructor was when stack classes had to have a constructor to be analyzed correctly. That's no longer the case, so I removed it. Also updated the newline, added context, and made the annotation style match the agreed formatting from the m.d.platform thread.
Attachment #327431 - Attachment is obsolete: true
Attachment #327433 - Flags: review?(dbaron)
Attachment #327431 - Flags: review?(dbaron)
Comment on attachment 327433 [details] [diff] [review]
Mark nsAutoString as stack-only, rev. 1.1

r=dbaron
Attachment #327433 - Flags: review?(dbaron) → review+
Assignee

Comment 4

11 years ago
Pushed to mozilla-central, revision 2a894be5a1b6
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.