442809 - [PATCH] respect application caches in imgLoader.cpp

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Dave Camp (:dcamp)]

Bug 442806 adds per-webapp caches that are associated with a given context.  These application caches affect loads, and are propagated through the loadgroup.

There are two problems with this in imgLoader.cpp:
a) The cache shouldn't reuse requests that came from one application cache to serve requests from another application cache (or not from an app cache at all).
b) The load group isn't passed on, so the channel doesn't know to use the application cache.

The attached patch tries to fix these two problems, by refusing to reuse cached requests that come from a different app cache, and by manually propagating the nsIApplicationCache instead of relying on the load group.

Comment 1

[Dave Camp (:dcamp)]

Attachment: v1

Comment 2

[Dave Camp (:dcamp)]

Attachment: updated for 430061

The patch in bug 430061 obsoletes v1.  New version of the patch is updated with that patch in mind.

Comment 3

[Dave Camp (:dcamp)]

Comment on attachment 328774 [details] [diff] [review]
updated for 430061

The latest version of the app-cache patch will pick up the application cache from either the notification callbacks or the load group's notification callbacks.  Since imgLoader passes on the docshell's notification callbacks, the part of this patch that propagates the application cache is no longer necessary.

We still need the change to avoid reusing requests from different application caches, I'll put together a new patch for that.

Comment 4

[Dave Camp (:dcamp)]

Attachment: fix

New version just refuses to reuse requests that come from a different app cache.

Comment 5

[Dave Camp (:dcamp)]

Landed on trunk as http://hg.mozilla.org/mozilla-central/rev/e9287c7efedc

Landed on 1.9.1 as http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c0d157855e30