Closed Bug 442862 Opened 12 years ago Closed 12 years ago

ext_state_multi_line and ext_state_single_line not exposed on HTML read-only textareas and textboxes.

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.1a1

People

(Reporter: MarcoZ, Assigned: MarcoZ)

References

Details

(Keywords: access, regression)

Attachments

(1 file)

Found this while developing test for bug 442648. This was introduced in bug 372367, where nsHTMLTextFieldAccessible::GetState bails out as soon as it finds there is no valid state pointer or the states don't contain ext_state_editable.
Attached patch PatchSplinter Review
Move the test for extraStates containing nsIAccessibleStates::EXT_STATE_EDITABLE to a point after checking for and assigning nsIAccessibleStates::EXT_STATE_SINGLE_LINE or nsIAccessibleStates::EXT_STATE_MULTI_LINE. This makes sure that even read-only textboxes and textareas get their proper states set.
Attachment #327566 - Flags: review?(surkov.alexander)
Comment on attachment 327566 [details] [diff] [review]
Patch

r=me
Attachment #327566 - Flags: review?(surkov.alexander) → review+
in-testsuite+ per bug 442648.
Assignee: nobody → marco.zehe
Flags: in-testsuite+
Pushed to mozilla-central in changeset:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/0f8bb55f95d9
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a1
You need to log in before you can comment on or make changes to this bug.