Closed
Bug 442939
Opened 17 years ago
Closed 17 years ago
[et] Firefox 3 protocol handler setup for Estonian
Categories
(Mozilla Localizations :: et / Estonian, defect)
Mozilla Localizations
et / Estonian
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Pike, Unassigned)
References
()
Details
(Keywords: fixed1.9.0.6, fixed1.9.1)
Attachments
(1 file)
1.37 KB,
patch
|
stas
:
review+
Pike
:
approval1.9.0.6+
|
Details | Diff | Splinter Review |
Protocol handlers are a new feature in Firefox 3 that allows links like mailto:nobody@mozilla.org to be handled by a webmail application.
In order to do that, the site needs to support a special API described on http://developer.mozilla.org/en/docs/Web-based_protocol_handlers.
For en-US, we're currently shipping with Yahoo! Mail for mailto: and 30boxes for webcal: urls, and we're on a ongoing evangelism effort to add more. For Estonian, we'd like to do that, too.
First, the localization team and Mic (Michal Berman) will look at the market for the language and come up with a good candidates. Sander, we'll need your input on this, the guidelines for making recommendations are on http://wiki.mozilla.org/Firefox_web_services_guidelines. Following that is a reach out by the evangelism team to try to get the vendor to support protocol handlers.
Once that happens, Axel will take over in reviewing the actual implementation, which will need to change the gecko.handlerService.* entries in et/browser/chrome/browser-region/region.properties. Please don't make changes to that file without getting a positive review by Axel or somebody else appointed by Mic on a patch for that change upfront.
Comment 1•17 years ago
|
||
on this bug i have no special input, Gmail is probably on of the most popular in Estonia after local mail service providers.
Reporter | ||
Updated•17 years ago
|
Component: Other → et / Estonian
QA Contact: estonian.et
Comment 2•17 years ago
|
||
Local mail service providers are exactly what we're looking for :) Can you point me to some of these, please? Maybe we can work together with them on the technical side to give more options to Estonian users!
Comment 3•17 years ago
|
||
i know such as www.hot.ee and www.mail.ee but people doesnt use them as much as gmail which is translated into estonian and gives a lot bigger inbox. If i'm correct then hot.ee and mail.ee still have inboxes ~10MB. This is something that's not enough today..
Comment 4•17 years ago
|
||
Yeah, I see your point. But still mail.ee and hot.ee seem to be quite popular among Estonian users (according to Alexa) and I believe we should always try to give our users more choice. Also, for users who already chose, providing these handlers will be a great user experience.
Let's include Gmail, hot.ee and mail.ee there. I'll contact hot.ee and mail.ee and see what is needed on their side to make this happen.
Also, what about the en-US defaults? Should we keep Yahoo Mail for mailto: and 30boxes for webcal: ? Any other ideas on webcal: handler BTW?
Comment 5•17 years ago
|
||
no more ideas here :)
Reporter | ||
Comment 6•17 years ago
|
||
There are technical docs on how to implement this on the server side on mdc, http://developer.mozilla.org/en/Web-based_protocol_handlers, and a flock of testcases at http://people.mozilla.org/~ctalbert/test-protocol-links.html.
Comment 7•17 years ago
|
||
No response from hot.ee nor mail.ee. Closing this bug as fixed with en-US defaults.
If we want to revisit the protocol handler setup for Estonian, let's file a new bug.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment 8•17 years ago
|
||
Reopening. The en-US defaults are missing in region.properties. Sander, can you copy them from http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser-region/region.properties (lines 19-36) and submit a patch for a review, please?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 9•17 years ago
|
||
i hope i got it right, still not very good at patching :)
Attachment #355121 -
Flags: review?(stas)
Comment 10•17 years ago
|
||
Comment on attachment 355121 [details] [diff] [review]
patch for bug #442939
Good job :) r=me. This patch should land on all 3 branches. I'm asking approval1.9.0.6 for the CVS landing. For 1.9.1 and central r+ is enough, please proceed with the landings. Thanks!
Attachment #355121 -
Flags: review?(stas)
Attachment #355121 -
Flags: review+
Attachment #355121 -
Flags: approval1.9.0.6?
Comment 11•17 years ago
|
||
1.9.1 and central are commited, do i have to commit cvs too or someone else will do it when it gets approval?
Comment 12•17 years ago
|
||
After the approval is granted feel free to land it on CVS as well. The essential part is that the code freeze for 3.0.6 is Jan 6 (Tuesday), so the patch will have to land before that. If you think you won't be able to land it before then, just let me know and I'll be happy to do it in your place.
For future reference, comment 11 mentions the following landings:
http://hg.mozilla.org/l10n-central/et/rev/a4cb43ebf1b5
http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/et/rev/5ced62b80258
Also, it's a good idea to include the bug number with short summary and the name or email address of the reviewer, e.g. "Bug 442939: Add en-US default protocol handlers, r=stas" or something like that. I should have mentioned that, sorry. That's OK for now, just making a note for the next time :)
Comment 13•17 years ago
|
||
Adding the fixed1.9.1 keyword. After you verify the change, please change it to "verified1.9.1". Same goes for 1.9.0.6 (after the approval, of course).
Keywords: fixed1.9.1
Reporter | ||
Comment 14•17 years ago
|
||
Comment on attachment 355121 [details] [diff] [review]
patch for bug #442939
a=me for landing in cvs. Please use a good check-in comment like stas mentioned earlier, something like "bug 442939, add protocol handlers, r=stas, a=l10n@mozilla.com" would do. Keywords as mentioned by stas, too :-)
Attachment #355121 -
Flags: approval1.9.0.6? → approval1.9.0.6+
Updated•17 years ago
|
Keywords: fixed1.9.0.6
Comment 15•17 years ago
|
||
Sander landed the change in cvs (rev. 1.5). Marking the bug as fixed. Thanks to all for a quick turnaround!
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•