442996 - Error status not reset upon successful sync

Status: RESOLVED FIXED

(Cloud Services :: General, defect, P3)

Description

[Mahesh Asolkar]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9) Gecko/2008052912 Firefox/3.0
Build Identifier: 0.2.0

There was some error using Weave 0.2.0 today, the status bar was showing an error status (marked by a yellow triangle with an exclamation mark). When I tried again, Weave sync'd successfully, but the error status icon is still being displayed in the status bar

Reproducible: Didn't try

Steps to Reproduce:
1. Get into a situation where sync fails (don't know how). A yellow triangle with an exclamation mark will show up in the status bar
2. Click on the yellow triangle
3. A dialog will slide in just above the icon. Click on the 'try again' button
4. Weave will sync again. Hopefully successfully, like in my case
Actual Results:  
After the successful sync, the yellow error status icon stays in the status bar. If you click on it, an empty dialog appears - no text, no buttons

Expected Results:  
After a successful sync, any error status indications from the status bar should disappear.

Off Topic, couldn't the error status icon not replace Weave icon, there by saving some real estate on my status bar?

Comment 1

[Dan Mills [:thunder]]

Yep, would like to see this.

It can't replace the Weave icon because it opens a different menu.

Comment 2

[Ed Lee :Mardak]

Actually.. did bug 481873 fix this? I'm trying to find other uses of the notification service, but it's only used for logins?

I suppose we could additionally clear all notifications on a successful sync as well....

Comment 3

[Ed Lee :Mardak]

Attachment: v1

We could just blindly clear all notifications on success..

Comment 4

[Dan Mills [:thunder]]

Comment on attachment 365901 [details] [diff] [review]
v1

Ideally this code would be better integrated with bug 481319.  It should update the status details/summary, and possibly also trigger notifications to be re-created form the current status.

Comment 5

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/a60dbca44f1f

Only clear out the sync failure messages instead of clearing out everything like bug 481873.