Closed
Bug 443005
Opened 16 years ago
Closed 16 years ago
Right-click on the weave menu should open the menu
Categories
(Cloud Services :: General, defect, P3)
Cloud Services
General
Tracking
(Not tracked)
RESOLVED
FIXED
0.3
People
(Reporter: hello, Assigned: Mardak)
References
Details
(Whiteboard: fixes bug 481868)
Right-clicking on the weave menu in the status bar should open the menu. Only left-click works atm.
Comment 1•16 years ago
|
||
I agree - right click would fit in more with usual UI conventions
Reporter | ||
Updated•16 years ago
|
Assignee | ||
Comment 2•16 years ago
|
||
http://hg.mozilla.org/labs/weave/rev/a6949112894f
Switched to statusbarpanel-iconic-text from statusbarpanel-menu-iconic so we don't reimplement adding the image and label -- instead just set the image/label attributes on the statusbarpanel.
I believe the problem was coming from menu-iconic being display=xul:menu, so only button=0 clicks transferred to the menu. Now that it's a plain button, we manually open the menu.
This also fixes bug 481868 because we were appending the menu on all clicks but only showing it on button=0.
Blocks: 481868
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: fixes bug 481868
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → edilee
Reporter | ||
Comment 3•16 years ago
|
||
This doesn't seem to be working for me. Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 4•16 years ago
|
||
Doh. That's what I get with testing on my MacBook! The original patch got ctrl-click working, but I just tried an actual mouse with a right-click and it didn't work..
http://hg.mozilla.org/labs/weave/rev/496f11796fa1
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Component: Weave → General
Product: Mozilla Labs → Weave
Updated•15 years ago
|
QA Contact: weave → general
You need to log in
before you can comment on or make changes to this bug.
Description
•