Closed Bug 443037 Opened 13 years ago Closed 13 years ago

basetext doesn't claim to implement nsIDOMXULLabeledControlElement

Categories

(Toolkit :: XUL Widgets, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla1.9.1a1

People

(Reporter: Fallen, Assigned: Fallen)

Details

(Keywords: access)

Attachments

(1 file, 1 obsolete file)

Attached patch Add implements (obsolete) — Splinter Review
The interface is implemented, but the binding doesn't claim to do so. This breaks accessibility for certain nodes where the accessible name should be read from the label instead of its child nodes.
Attachment #327688 - Flags: superreview?(enndeakin)
Attachment #327688 - Flags: review?(enndeakin)
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #327688 - Flags: superreview?(enndeakin)
Attachment #327688 - Flags: review?(enndeakin)
Attachment #327688 - Flags: review+
removed redundant implements="... nsIDOMXULLabeled..." from radio.xml, carrying r+ forth as discussed.

Also requesting approval for 1.9.0 since this would improve the situation for lightning trunk with thunderbird 3.
Attachment #327688 - Attachment is obsolete: true
Attachment #327847 - Flags: review+
Attachment #327847 - Flags: approval1.9.0.1?
Attachment #327847 - Flags: approval1.9.0.1? → approval1.9.0.2?
Checked in, changeset 15642:61419364c2d3

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1
Target Milestone: mozilla1.9.1 → mozilla1.9.1a1
Version: unspecified → Trunk
Philipp, since Thunderbird is moving to hg, do you still need this in CVS?
Comment on attachment 327847 [details] [diff] [review]
Add implements - v2

You are right, 1.9.0 support not needed any longer.
Attachment #327847 - Flags: approval1.9.0.2?
You need to log in before you can comment on or make changes to this bug.