443037 - basetext doesn't claim to implement nsIDOMXULLabeledControlElement

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Add implements

The interface is implemented, but the binding doesn't claim to do so. This breaks accessibility for certain nodes where the accessible name should be read from the label instead of its child nodes.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Add implements - v2

removed redundant implements="... nsIDOMXULLabeled..." from radio.xml, carrying r+ forth as discussed.

Also requesting approval for 1.9.0 since this would improve the situation for lightning trunk with thunderbird 3.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Checked in, changeset 15642:61419364c2d3

-> FIXED

Comment 3

[Samuel Sidler (old account; do not CC)]

Philipp, since Thunderbird is moving to hg, do you still need this in CVS?

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 327847 [details] [diff] [review]
Add implements - v2

You are right, 1.9.0 support not needed any longer.