44323 - Save As Charset dialog title is displayed with garbage

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Ryoichi Furukawa]

Steps of reproduce
1. Open Composer
2. Select File|Sava As Charset and open dialog

title is "Save As Charset"

3. select UTF-8(or any charset)
4. *Not* enter in page title. (makes blank)
5. select OK

dialog title is changed, and displayed with garbage.

I tested with BuildID:20000062920 on WinNT4/SP5.

Comment 1

[nhottanscp]

Attachment: a screen shot

Comment 2

[nhottanscp]

Reproducible, reassign to editor group.

Comment 3

[Teruko Kobayashi]

This does not happen in 2000-06-30-08 Win32 build.

Comment 4

[Teruko Kobayashi]

I am sorry, I did not click OK button.  I could reproduce it.
This is related to the bug 40739.

Comment 5

[rubydoo123]

assigning this over to jfrancis

Comment 6

[Joe Francis]

umm, this should be cmanske or ftang, it appears, given the checkin history to 
EditorSaveAsCharset.js.

bumping over to Charlie for disposition...

Comment 7

[Charles Manske]

I don't see any problem here -- Frank just checked in fix for 40739 today,
so maybe this is a dup of that problem.
I'll let ftang confirm this.

Comment 8

[Frank Tang]

Please do not assign "Save As Charset" bug to editor group. It is my code and I 
don't want to wast cmanske's time until I really need their help.

teruko, can you try to reproduce it again ?

Comment 9

[Frank Tang]

Mark this as fix. I believe this is fixed while I fix 40739. Please reopen it if
it still happen.

Comment 10

[Teruko Kobayashi]

I tested this in 2000-08-25-08 Win32 build. This still happen. Reopenning..

Comment 11

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 12

[Frank Tang]

reassign this bug to yokoyama. Mark it as Moz 0.9 P3.

Comment 13

[Yuying Long]

I did see this in 01-16 Mtrunk build.

Comment 14

[nhottanscp]

Reassign to jbetak.

ylong, please test with the latest build.

Comment 15

[Yuying Long]

I didn't see it on 03-27 Win32 trunk build(cause the other 2 platform builds not 
avalible at this point) and 03-16/19 Linux and Mac trunk build.

Comment 16

[Roy Yokoyama]

This still happens. 
As per nhotta's assignment (2001-03-27 10:46), I am assign this to jbetak.
It looks though the assignment never took place. 

Comment 17

[[e-mail] (away - not reading bugmail)]

accepting, targeting 0.9.2

Comment 18

[[e-mail] (away - not reading bugmail)]

Attachment: cvs diff -w -u -b editor/ui

Comment 19

[[e-mail] (away - not reading bugmail)]

looks like editorShell.SetDocumentTitle was setting the title for both the 
parent and the charset dialog window. I moved it into ComposerCommands.js and 
while at it I also refactored some (seemingly random) bits of code ...

nhotta (yokoyama): would you care to review?

Comment 20

[nhottanscp]

The code in ComposerCommands.js is non specific to saveascharset, right?
Does you change affects others (e.g. save, saveas)?

Comment 21

[[e-mail] (away - not reading bugmail)]

Naoki,

this affects SaveAsCharset only. I copied the whole code section below for 
easier verification:

var nsSaveAsCharsetCommand =
{
  isCommandEnabled: function(aCommand, dummy)
  {
    return (window.editorShell && window.editorShell.documentEditable);
  },
  doCommand: function(aCommand)
  {    
    FinishHTMLSource();
    window.ok = false;
    window.exportToText = false;
    window.openDialog
("chrome://editor/content/EditorSaveAsCharset.xul","_blank", "chrome,close,title
bar,modal,resizable=yes");

    if (window.newTitle != null) {
      try {
        editorShell.SetDocumentTitle(window.newTitle);
      } 
      catch (ex) {}
    }    

    if (window.ok)
    {
      if (window.exportToText)
      {
        window.ok = window.editorShell.saveDocument(true, true, "text/plain");
      }
      else
      {
        window.ok = window.editorShell.saveDocument(true, false, 
editorShell.contentsMIMEType);
      }
    }

    window._content.focus();
    return window.ok;
  }
};

Comment 22

[nhottanscp]

r=nhotta

Comment 23

[Frank Tang]

Since this is not moz0.9.2 critical, move it to moz0.9.3. 
cmanske- this is under your code. please review it. thanks.

Comment 24

[Frank Tang]

add cmanske to the cc list. 

Comment 25

[Charles Manske]

r=cmanske
Looks good!

Comment 26

[[e-mail] (away - not reading bugmail)]

cmanske: thanks for taking time to review this!

adding alecf for sr= and blizzard for a=

Comment 27

[Alec Flett]

sr=alecf

Comment 28

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 29

[nhottanscp]

checked in

Comment 30

[nhottanscp]

checked in

Comment 31

[[e-mail] (away - not reading bugmail)]

Naoki, thanks for helping to obtain the sr=, a= and for landing this!

Comment 32

[Yuying Long]

Verified on 06-15-06 trunk build.