Closed Bug 443410 Opened 11 years ago Closed 11 years ago

filefield author doesn't know how to write efficient CSS

Categories

(Toolkit :: Preferences, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.1a1

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: perf)

Attachments

(1 file)

filefield[disabled="true"] .fileFieldContentBox
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #327954 - Flags: review?(gavin.sharp)
Comment on attachment 327954 [details] [diff] [review]
Proposed patch (untested)

>--- browser/themes/gnomestripe/browser/preferences/preferences.css	11 Mar 2008 08:12:06 -0000	1.28
>+++ browser/themes/gnomestripe/browser/preferences/preferences.css	3 Jul 2008 13:45:46 -0000

Why are these in a browser specific file anyways? They're forked into /mail/ and /calendar/ as well... fix those too, and file a bug on consolidating the styles in toolkit?
Attachment #327954 - Flags: review?(gavin.sharp) → review+
(In reply to comment #2)
> Why are these in a browser specific file anyways?
If they were really toolkit then they'd live in toolkit/content.

> They're forked into /mail/ and /calendar/ as well... fix those too
I wanted to wait for them to move to Mercurial too first.
Keywords: checkin-needed
(In reply to comment #3)
> (In reply to comment #2)
> > Why are these in a browser specific file anyways?
> If they were really toolkit then they'd live in toolkit/content.

I don't understand what you mean. The binding is in /toolkit, so it's styling should be in toolkit too. I don't think the toolkit/mozapps vs. toolkit/content distinction is important.

> > They're forked into /mail/ and /calendar/ as well... fix those too
> I wanted to wait for them to move to Mercurial too first.

Sure - get a bug on file?
(In reply to comment #4)
> Sure - get a bug on file?
If the styles get consolidated into toolkit then that won't be necessary.
http://hg.mozilla.org/index.cgi/mozilla-central/rev/9e98808652ff
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a1
Blocks: 459372
You need to log in before you can comment on or make changes to this bug.