443410 - filefield author doesn't know how to write efficient CSS

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect)

Description

[[e-mail]]

filefield[disabled="true"] .fileFieldContentBox

Comment 1

[[e-mail]]

Attachment: Proposed patch (untested)

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 327954 [details] [diff] [review]
Proposed patch (untested)

>--- browser/themes/gnomestripe/browser/preferences/preferences.css	11 Mar 2008 08:12:06 -0000	1.28
>+++ browser/themes/gnomestripe/browser/preferences/preferences.css	3 Jul 2008 13:45:46 -0000

Why are these in a browser specific file anyways? They're forked into /mail/ and /calendar/ as well... fix those too, and file a bug on consolidating the styles in toolkit?

Comment 3

[[e-mail]]

(In reply to comment #2)
> Why are these in a browser specific file anyways?
If they were really toolkit then they'd live in toolkit/content.

> They're forked into /mail/ and /calendar/ as well... fix those too
I wanted to wait for them to move to Mercurial too first.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #3)
> (In reply to comment #2)
> > Why are these in a browser specific file anyways?
> If they were really toolkit then they'd live in toolkit/content.

I don't understand what you mean. The binding is in /toolkit, so it's styling should be in toolkit too. I don't think the toolkit/mozapps vs. toolkit/content distinction is important.

> > They're forked into /mail/ and /calendar/ as well... fix those too
> I wanted to wait for them to move to Mercurial too first.

Sure - get a bug on file?

Comment 5

[[e-mail]]

(In reply to comment #4)
> Sure - get a bug on file?
If the styles get consolidated into toolkit then that won't be necessary.

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/index.cgi/mozilla-central/rev/9e98808652ff