44355 - Tooltips look silly in Classic skin

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P3)

Description

[Jerry Baker]

The tooltips in the Classic skin look silly, here is a patch that makes them 
identical to Window "real" tooltips except for the system font.

Comment 1

[Jerry Baker]

Attachment: Proposed patch to fix Windoze tooltips in Classic skin

Comment 2

[hangas]

Nikhil please see if you can apply this patch to fix the windows tooltips and 
also make sure Mac and Linux look good.

Comment 3

[[e-mail]]

Personally I think that the following settings should be used:
    border                : 1px solid windowframe;
    padding               : none;

Comment 4

[Jerry Baker]

Padding none does not look like a real Windows tooltip. See attachment. Maybe 
1px will work here.

Comment 5

[Jerry Baker]

Attachment: Various paddings.

Comment 6

[Lakespur Roca]

I checked out all sorts of padding, ranging from 0px to 2px along all four 
sides, and i think this looks the best:

       padding : 0px 1px 0px 2px;

Any comments?  It is slightly off-centered, but if you look at windows tooltips, 
you'll see something similar.

Comment 7

[Nikhil Bhatla (gone)]

That last comment was from me, not Lake.  Old cookie on this PC i guess.

Comment 8

[Jerry Baker]

Anything in particular holding up a check in of one of these patches, or is it 
just that busy around there?

Comment 9

[Nikhil Bhatla (gone)]

I'll submit the fix hopefully sometime today

Comment 10

[Nikhil Bhatla (gone)]

Ok, I finallu checked the code in to fix the tooltip.  Let me know how it looks.

Comment 11

[Blake Ross]

marking fixed

Comment 12

[Joseph Elwell]

They look like buttons! that's worse than silly, people are going to try to
click on these things, and become frustrated when they fail.

Comment 13

[Jerry Baker]

Tooltips in the classic Windows skin are OK. I guess we should solicit patches 
for each of the platforms so that they can all have native looking tooltips. Not 
sure about modern, but I don't think many people will be using the modern skin 
anyway.

Comment 14

[Nikhil Bhatla (gone)]

Joseph, what platform are you on?  I'm not seeing this in Win98.  Be sure to 
check tomorrow's verified build for the complete fix.

Comment 15

[Nikhil Bhatla (gone)]

If there are no more complaints, I'm marking this one as fixed

Comment 16

[Jerry Baker]

Why were the tooltips changed to padding: 2px? They look too "fat" on Windows.

Comment 17

[Blake Ross]

For what it's worth, tooltips in the win32 072608 build with the classic skin 
on look absolutely fine to me, and exactly as windows tooltips should look...

Comment 18

[Jerry Baker]

Attachment: Compare "real" vs. Mozilla tooltips with padding: 2px

Comment 19

[Nikhil Bhatla (gone)]

The reason I changed it to 2px is because Windows (at least Win98) is
inconsistent in its tool-tip padding.  Netscape 4.x/IE 5 tooltips on Windows
have padding of 3px top, 2px right, 3px bottom, and 3px left.  Note that this
isn't necessarily the "padding: " style values, but the actual end pixel counts
so it includes margin spacing as well.  The Windows inconsistency is here: On
the "Minimize/Maximize" tooltips, the padding is 4px top, 2px right, 4px bottom,
and 3px left.

In an effort to maintain some consistency within this inconsistency (even the
AOL client has abnormal paddings even larger than these, as do other apps), I
chose to follow exactly what Win 98 system services do (like the "Minimize"
tooltip).  This is the reason for the padding: 2px setting.

Comment 20

[Blake Ross]

In 2000072708 WinNT4, the tooltips for the classic skin now seem to be back to 
how they are in the Modern skin.  How'd that happen?

Comment 21

[Jerry Baker]

Yep. Ben Goodger changed them back on the 26th. Ugh.

Comment 22

[Nikhil Bhatla (gone)]

I'll talk to Ben and get this fixed.

Comment 23

[Nikhil Bhatla (gone)]

-> ben, who made the changes because he wanted the tooltips to match 
Office 2K look

Comment 24

[Ben Goodger (use ben at mozilla dot org for email)]

Intentional. Office 2000 tooltips look like this, & they look nothing at all 
like buttons. 

Comment 25

[Blake Ross]

The tooltips seem to look a little better (or their borders do) without the 
infobackground...what's that used for?

Comment 26

[[e-mail]]

I disagree with the proposed patch. I use this instead:

.tooltip
  {
    background-color : infobackground;
    border : 1px solid windowframe;
    color : infotext;
    font : smaller;
    padding : 0px 1px 0px 1px;
  }

Comment 27

[Ben Goodger (use ben at mozilla dot org for email)]

actually, after playing with the outset borders for a few days, I agree. I like 
the windows look better. reopening ;) 

Comment 28

[Ben Goodger (use ben at mozilla dot org for email)]

have the modified patch in my tree, will commit with next round of classic skin 
changes. 

Comment 29

[sean echevarria]

I think you also need to specify text color in this section as well:

.tooltip > .popup-internal-box
  {
  	border: 0px;
+  	color: infotext;
  	padding: 0px;
  }

Comment 30

[Ben Goodger (use ben at mozilla dot org for email)]

this is fixed. 

Comment 31

[Blake Ross]

so let's mark it as such

Comment 32

[Paul Wyskoczka]

Updated QA contact

Comment 33

[Patty Mac]

Fixed in windows (2000-09-11-08-M18).

Comment 34

[Jerry Baker]

Mass removing self from CC list.

Comment 35

[Jerry Baker]

Now I feel sumb because I have to add back. Sorry for the spam.