Closed Bug 4437 Opened 21 years ago Closed 21 years ago

[FEATURE] Convert browser appcore to XPIDL

Categories

(SeaMonkey :: UI Design, defect, P1)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: waterson, Assigned: law)

Details

(Whiteboard: Bill sez this is almost done)

Any appcore interface (or XPIDL component interface, for that matter) that can
be called from JavaString *MUST* be rigorous about testing for null pointers in
the parameter list, and bailing if it gets one. The browser appcore is
especially sloppy.

Cut and paste this code:

NS_PRECONDITION(aParam != nsnull, "null ptr");
if (! aParam)
    return NS_ERROR_NULL_POINTER;
AppCore is going away, AFAIK. Maybe there's a corresponding change to be made
elsewhere though.
Component: Apprunner → XPApps
Priority: P3 → P1
Target Milestone: M5
Set target milestone to M5 and changed component to XPApps and priority to P1.
Target Milestone: M5 → M6
Set target milestone to M6.
Updating QA Contact.
Target Milestone: M6 → M7
Looks like we can't finish this until M7.  Stay tuned.
Target Milestone: M7 → M9
Bill will likely continue working on this for the next two milestones ...
Assignee: don → law
Summary: clean up appcore interfaces → [FEATURE] Convert browser appcore to XPIDL
Target Milestone: M9 → M10
Changed summary to feature and re-assigned to Bill.
OS: Windows NT → All
Status: NEW → ASSIGNED
Blocks: 10575
Whiteboard: Bill sez this is almost done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Done.  We now have nsIBrowserInstance defined in xpidl and its implementation in
mozilla/xpfe/browser/src/nsBrowserInstance.*.
Status: RESOLVED → VERIFIED
looks good!
No longer blocks: 10575
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.