The default bug view has changed. See this FAQ.

Extra semicolon in PKM_TLSKeyAndMacDerive makes "conditional" code unconditional

RESOLVED FIXED in 3.12.1

Status

NSS
Tools
P2
normal
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Jesse Ruderman, Assigned: glen beasley)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.10 KB, patch
glen beasley
: review+
Nelson Bolyard (seldom reads bugmail)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

9 years ago
Created attachment 328231 [details] [diff] [review]
patch

This bug was discovered by the reporter of bug 440771:

  security/nss/cmd/pk11mode/pk11mode.c:5018
  if (kmo.hClientKey != CK_INVALID_HANDLE);

Glen, if you like this patch, can you check it into the appropriate repository for me?
Attachment #328231 - Flags: review?(glen.beasley)
(Reporter)

Updated

9 years ago
Status: NEW → ASSIGNED
Assignee: jruderman → nobody
Status: ASSIGNED → NEW
Component: Test → Tools
Priority: -- → P2
QA Contact: test → tools
Version: unspecified → 3.12
Jesse, to whom should credit for the patch go?  
To you? or to the reporter of bug 440771 ?
Assignee: nobody → glen.beasley
Comment on attachment 328231 [details] [diff] [review]
patch

I assigned to Glen for the checkin.  I believe Glen is on leave now, for a brief time, but will attend to this upon his return.
Attachment #328231 - Flags: review+
(Reporter)

Comment 3

9 years ago
I don't really care who gets credit for the patch.  Finding the bug was the hard part, and credit for that goes to the reporter of bug bug 440771 ;)
(Assignee)

Comment 4

9 years ago
Comment on attachment 328231 [details] [diff] [review]
patch

Thanks Jesse for the patch. Checked in current source which is 3.12.1 beta. 

/cvsroot/mozilla/security/nss/cmd/pk11mode/pk11mode.c,v  <--  pk11mode.c
new revision: 1.18; previous revision: 1.17
done
Attachment #328231 - Flags: review?(glen.beasley) → review+
(Assignee)

Updated

9 years ago
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.12.1
You need to log in before you can comment on or make changes to this bug.