Last Comment Bug 443755 - Extra semicolon in PKM_TLSKeyAndMacDerive makes "conditional" code unconditional
: Extra semicolon in PKM_TLSKeyAndMacDerive makes "conditional" code unconditional
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Tools (show other bugs)
: 3.12
: All All
: P2 normal (vote)
: 3.12.1
Assigned To: glen beasley
:
:
Mentors:
Depends on:
Blocks: InspectTool
  Show dependency treegraph
 
Reported: 2008-07-05 15:24 PDT by Jesse Ruderman
Modified: 2008-07-09 11:10 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (1.10 KB, patch)
2008-07-05 15:24 PDT, Jesse Ruderman
glenbeasley: review+
nelson: review+
Details | Diff | Splinter Review

Description Jesse Ruderman 2008-07-05 15:24:37 PDT
Created attachment 328231 [details] [diff] [review]
patch

This bug was discovered by the reporter of bug 440771:

  security/nss/cmd/pk11mode/pk11mode.c:5018
  if (kmo.hClientKey != CK_INVALID_HANDLE);

Glen, if you like this patch, can you check it into the appropriate repository for me?
Comment 1 Nelson Bolyard (seldom reads bugmail) 2008-07-05 20:47:30 PDT
Jesse, to whom should credit for the patch go?  
To you? or to the reporter of bug 440771 ?
Comment 2 Nelson Bolyard (seldom reads bugmail) 2008-07-05 20:49:43 PDT
Comment on attachment 328231 [details] [diff] [review]
patch

I assigned to Glen for the checkin.  I believe Glen is on leave now, for a brief time, but will attend to this upon his return.
Comment 3 Jesse Ruderman 2008-07-06 01:16:44 PDT
I don't really care who gets credit for the patch.  Finding the bug was the hard part, and credit for that goes to the reporter of bug bug 440771 ;)
Comment 4 glen beasley 2008-07-09 11:09:50 PDT
Comment on attachment 328231 [details] [diff] [review]
patch

Thanks Jesse for the patch. Checked in current source which is 3.12.1 beta. 

/cvsroot/mozilla/security/nss/cmd/pk11mode/pk11mode.c,v  <--  pk11mode.c
new revision: 1.18; previous revision: 1.17
done

Note You need to log in before you can comment on or make changes to this bug.