Closed
Bug 443755
Opened 16 years ago
Closed 16 years ago
Extra semicolon in PKM_TLSKeyAndMacDerive makes "conditional" code unconditional
Categories
(NSS :: Tools, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
3.12.1
People
(Reporter: jruderman, Assigned: glenbeasley)
References
Details
Attachments
(1 file)
|
1.10 KB,
patch
|
glenbeasley
:
review+
nelson
:
review+
|
Details | Diff | Splinter Review |
This bug was discovered by the reporter of bug 440771:
security/nss/cmd/pk11mode/pk11mode.c:5018
if (kmo.hClientKey != CK_INVALID_HANDLE);
Glen, if you like this patch, can you check it into the appropriate repository for me?
Attachment #328231 -
Flags: review?(glen.beasley)
|
Reporter | |
Updated•16 years ago
|
Status: NEW → ASSIGNED
|
||
Updated•16 years ago
|
Assignee: jruderman → nobody
Status: ASSIGNED → NEW
Component: Test → Tools
Priority: -- → P2
QA Contact: test → tools
Version: unspecified → 3.12
|
|
||
Comment 1•16 years ago
|
||
Jesse, to whom should credit for the patch go?
To you? or to the reporter of bug 440771 ?
Assignee: nobody → glen.beasley
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 328231 [details] [diff] [review]
patch
I assigned to Glen for the checkin. I believe Glen is on leave now, for a brief time, but will attend to this upon his return.
Attachment #328231 -
Flags: review+
|
|
Reporter | |
Comment 3•16 years ago
|
||
I don't really care who gets credit for the patch. Finding the bug was the hard part, and credit for that goes to the reporter of bug bug 440771 ;)
|
Assignee | |
Comment 4•16 years ago
|
||
Comment on attachment 328231 [details] [diff] [review]
patch
Thanks Jesse for the patch. Checked in current source which is 3.12.1 beta.
/cvsroot/mozilla/security/nss/cmd/pk11mode/pk11mode.c,v <-- pk11mode.c
new revision: 1.18; previous revision: 1.17
done
Attachment #328231 -
Flags: review?(glen.beasley) → review+
|
|
Assignee | |
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.12.1
You need to log in
before you can comment on or make changes to this bug.
Description
•