443756 - Extra semicolon in OS/2 RWS code makes "conditional" code unconditional

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Jesse Ruderman]

Attachment: patch

From the reporter of bug 440771:

uriloader/exthandler/os2/nsOSHelperAppService.cpp:1464  
if ((pos = fileType.Find("%S")) > -1);

widget/src/os2/nsRwsService.cpp:467                     
if ((pos = classViewer.Find("%S")) > -1);

Both of these lines were added in bug 305061.  Peter, can you verify that the patch I'm attaching matches your intent with this code, and comment on the impact of the bug?  Also, tell me if you think the patch needs more than just your review before it is checked in.

Comment 1

[Peter Weilbacher]

Comment on attachment 328232 [details] [diff] [review]
patch

Jesse, thanks for fixing this! Unless a translator by mistake removed the %S from the string, there shouldn't have been a problem. That's probably why these typos escaped my testing before.

Yes, my review is good enough for OS/2-only files; for those, branch approval isn't usually needed.

Comment 2

[Jesse Ruderman]

Fixed on trunk.  Did you want the patch on a branch too?

Comment 3

[Peter Weilbacher]

Jesse, yes, getting this into CVS would be great. Thanks!

Comment 4

[Peter Weilbacher]

OK, I landed this in CVS just now.