443760 - Extra semicolon in SeqDatabase makes static analysis tool suspicious

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Jesse Ruderman]

Attachment: patch

From the reporter of bug 440771:

dbm/tests/lots.c:211

        while(!(status = (database->seq) (database, &key, &data, R_NEXT)));
			; /* null body */

Removing the semicolon from the first line won't change the compiled code, since the body of the while loop is empty anyway.  So I don't think I need code review.

Which repository do mozilla/dbm patches go into?  mozilla-central?

Comment 1

[[e-mail]]

(In reply to comment #0)
>         while(!(status = (database->seq) (database, &key, &data, R_NEXT)));
>                         ; /* null body */
This might be more readable as a do loop:
do {
  status = (database->seq) (database, &key, &data, R_NEXT);
} while (!status);

Comment 2

[Wan-Teh Chang]

Comment on attachment 328234 [details] [diff] [review]
patch

r=wtc.  The master source of mozilla/dbm is in the CVS repository.
It is now maintained by the NSS team.

Comment 3

[Jesse Ruderman]

Thanks, wtc.  Can you check it in for me or CC someone who can?

Comment 4

[Wan-Teh Chang]

I checked in your patch on the NSS trunk for NSS 3.12.1.

Checking in lots.c;
/cvsroot/mozilla/dbm/tests/lots.c,v  <--  lots.c
new revision: 3.15; previous revision: 3.14
done

Please don't check in this patch in mozilla-central.  We
want to keep the copy of NSS in mozilla-central identical
to snapshots provided by the NSS team.