Closed
Bug 443769
Opened 17 years ago
Closed 17 years ago
[FIX]IsJProfAction condition is probably incorrect due to operator precedence
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
897 bytes,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/dom/src/base/nsJSEnvironment.cpp&rev=1.399&mark=3032#3024
The reporter of bug 440771 pointed out this problem, saying "== has precedence over |, need () or ???".
action->sa_flags == SA_RESTART | SA_SIGINFO);
Putting parens around "SA_RESTART | SA_SIGINFO" would make tools stop complaining about an always-true condition, but I have no idea if that's the right fix.
|
Assignee | |
Comment 1•17 years ago
|
||
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #337107 -
Flags: superreview?(dbaron)
Attachment #337107 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•17 years ago
|
Summary: IsJProfAction condition is probably incorrect due to operator precedence → [FIX]IsJProfAction condition is probably incorrect due to operator precedence
Comment on attachment 337107 [details] [diff] [review]
This is definitely what we want
r+sr=dbaron
Attachment #337107 -
Flags: superreview?(dbaron)
Attachment #337107 -
Flags: superreview+
Attachment #337107 -
Flags: review?(dbaron)
Attachment #337107 -
Flags: review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Pushed changeset f3d3c41fa686
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Component: DOM: Mozilla Extensions → DOM
|
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•