443777 - [es-ES] - two hotkeys do the same

Status: RESOLVED FIXED

(Mozilla Localizations :: es-ES / Spanish, defect)

Description

[Hugo Osvaldo Barrera]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.2; en-GB; rv:1.9) Gecko/2008052906 Firefox/3.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-GB; rv:1.9) Gecko/2008052906 Firefox/3.0

in the spanish instller, the license screen has

Aceptar - "Accept" (alt+a)
Atrás - "Back" (alt+a)

the same hotkey for two purposes. can't accept license via alt+a (as is indicated)

Reproducible: Always

Steps to Reproduce:
1.run spanish installer
2.press alt+a in the license screen to accept it
Actual Results:  
alt+a will bring you to the last page

Expected Results:  
selece the "accept licence box"

be sure to unset the "hid underlined letters for keyboard navitation until i press the alt key" in windows to actualy see they're both the same hotkey


this bug is not unusual in spanish installer
C (alt+c) is usualy used for "accept license" (aceptar) in spanish installers

Comment 1

[Guillermo López :willyaranda (probably SLOW response)]

Ricardo, I can't find the strings on the "browser" module.

http://mxr.mozilla.org/l10n/source/es-ES/browser/installer/mui.properties ?

I don't know where is it :S

Comment 2

[RickieES aka Ricardo Palomares]

(In reply to comment #1)
> Ricardo, I can't find the strings on the "browser" module.
> 
> http://mxr.mozilla.org/l10n/source/es-ES/browser/installer/mui.properties ?
> 
> I don't know where is it :S


That's why those strings don't exist. The correct ones are:

< &Anterior
http://mxr.mozilla.org/l10n/source/es-ES/browser/installer/override.properties#39

and

&Acepto los términos del acuerdo de licencia
http://mxr.mozilla.org/l10n/source/es-ES/browser/installer/override.properties#41


The first one is overriding this other one:

< An&terior
http://mxr.mozilla.org/l10n/source/es-ES/toolkit/installer/windows/install.it#30

So, I would suggest to change override.properties -> BackBtn to mimic install.it. I've just reviewed the installation wizard steps and "t" won't conflict with any other accesskey during installation.

Comment 3

[Guillermo López :willyaranda (probably SLOW response)]

Attachment: Patch for the bug

Patch for the bug.

Bug 437405 is not solved and checked in yet, so I attach a patch to this bug with the solution for the other bug too.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 328275 [details] [diff] [review]
Patch for the bug

r-, see the other bug.

Comment 5

[Guillermo López :willyaranda (probably SLOW response)]

guillermo@guillermo-laptop:~/MT/firefox/trunk/l10n/es-ES/browser/installer$ ./commit-patch -m "bug443777 and bug 437405. Changed an accesskey, removed newlines and fix codification. Patch by Guillermo, r=[e-mail]" override-patch.diff
Checking in override.properties;
/l10n/l10n/es-ES/browser/installer/override.properties,v  <--  override.properties
new revision: 1.5; previous revision: 1.4
done
guillermo@guillermo-laptop:~/MT/firefox/trunk/l10n/es-ES/browser/installer$ 


http://l10n.mozilla.org/buildbot/builders/linux-langpack/builds/11269

Checked in:

http://bonsai-l10n.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/l10n&subdir=l10n/es-ES/browser/installer&command=DIFF_FRAMESET&root=/l10n&file=override.properties&rev1=1.4&rev2=1.5

And build:

http://l10n.mozilla.org/buildbot/builders/linux-langpack/builds/11269

Comment 6

[Hugo Osvaldo Barrera]

i'm a bit confused
language es-AR had the same bug, will this patch be applied to it as well?

Comment 7

[Guillermo López :willyaranda (probably SLOW response)]

Adding Marcelo Poli to the bug.

But, please, fill a new bug.

Comment 8

[Hugo Osvaldo Barrera]

a new bug? i already posted this one :P 
i'm just trying to make sure this patch algo applies to es-AR

Comment 9

[Hugo Osvaldo Barrera]

i originaly posted "spanish" insead of es-ES or es-AR, since the bug applies to BOTH

Comment 10

[Guillermo López :willyaranda (probably SLOW response)]

we need two different bugs for two different locales.

Hugo, can you download a es-ES version and check if the change is correct?

thanks!