Closed Bug 443843 Opened 12 years ago Closed 12 years ago
valgrind errors in sessionstore mochitest chrome tests
These are JS Engine errors.
if ((!js_IdIsIndex(id, &i) && id != ATOM_TO_JSID(cx->runtime->atomState.lengthAtom)) || obj->fslots[JSSLOT_ARRAY_LENGTH] == 0 || i >= ARRAY_DENSE_LENGTH(obj) || obj->dslots[i] == JSVAL_HOLE) If the first || left-hand side is false, then either js_IdIsIndex(id, &i), in which case i will be set, or id == 'length', in which case i will not be set and the use of i in the fourth line will UMR. /be
Assignee: general → shaver
That...could be true, yes. *blush* I'll patch this today, unless someone beats me to it. sayrer: is there a ready-to-go setup on sm-valgrind for me to test this on? I don't have a Linux VM or desktop install atm.
I just ran this patch through mochitests and things came out clean .  I did leak a bunch of stuff, but in my recollection, I've never *not* leaked when running a full set of MochiTests in a debug build.
Assignee: shaver → mrbkap
Status: NEW → ASSIGNED
Attachment #328325 - Flags: review?(shaver)
Comment on attachment 328325 [details] [diff] [review] Proposed fix r=shaver, thanks
Attachment #328325 - Flags: review?(shaver) → review+
Pushed as changeset 6059b09ca278.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 328325 [details] [diff] [review] Proposed fix I'm guessing we want this on the 1.9 branch.
Attachment #328325 - Flags: approval18.104.22.168?
Comment on attachment 328325 [details] [diff] [review] Proposed fix Approved for 22.214.171.124. Please land in CVS. a=ss
Attachment #328325 - Flags: approval126.96.36.199? → approval188.8.131.52+
Fix checked into the 1.9 branch.
You need to log in before you can comment on or make changes to this bug.