Closed
Bug 443843
Opened 16 years ago
Closed 16 years ago
valgrind errors in sessionstore mochitest chrome tests
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sayrer, Assigned: mrbkap)
References
Details
(Keywords: fixed1.9.0.2, intermittent-failure, valgrind)
Attachments
(2 files)
2.44 KB,
text/plain
|
Details | |
917 bytes,
patch
|
shaver
:
review+
samuel.sidler+old
:
approval1.9.0.2+
|
Details | Diff | Splinter Review |
These are JS Engine errors.
Reporter | ||
Comment 1•16 years ago
|
||
Comment 2•16 years ago
|
||
if ((!js_IdIsIndex(id, &i) && id != ATOM_TO_JSID(cx->runtime->atomState.lengthAtom)) || obj->fslots[JSSLOT_ARRAY_LENGTH] == 0 || i >= ARRAY_DENSE_LENGTH(obj) || obj->dslots[i] == JSVAL_HOLE) If the first || left-hand side is false, then either js_IdIsIndex(id, &i), in which case i will be set, or id == 'length', in which case i will not be set and the use of i in the fourth line will UMR. /be
Assignee: general → shaver
Comment 3•16 years ago
|
||
That...could be true, yes. *blush* I'll patch this today, unless someone beats me to it. sayrer: is there a ready-to-go setup on sm-valgrind for me to test this on? I don't have a Linux VM or desktop install atm.
Flags: wanted1.9.0.x?
Assignee | ||
Comment 4•16 years ago
|
||
I just ran this patch through mochitests and things came out clean [1]. [1] I did leak a bunch of stuff, but in my recollection, I've never *not* leaked when running a full set of MochiTests in a debug build.
Comment 5•16 years ago
|
||
Comment on attachment 328325 [details] [diff] [review] Proposed fix r=shaver, thanks
Attachment #328325 -
Flags: review?(shaver) → review+
Assignee | ||
Comment 6•16 years ago
|
||
Pushed as changeset 6059b09ca278.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•16 years ago
|
||
Comment on attachment 328325 [details] [diff] [review] Proposed fix I'm guessing we want this on the 1.9 branch.
Attachment #328325 -
Flags: approval1.9.0.2?
Updated•16 years ago
|
Flags: in-testsuite+
Flags: in-litmus-
Comment 8•16 years ago
|
||
Comment on attachment 328325 [details] [diff] [review] Proposed fix Approved for 1.9.0.2. Please land in CVS. a=ss
Attachment #328325 -
Flags: approval1.9.0.2? → approval1.9.0.2+
Updated•16 years ago
|
Flags: wanted1.9.0.x? → wanted1.9.0.x+
Updated•16 years ago
|
Whiteboard: [orange]
Updated•12 years ago
|
Keywords: intermittent-failure
Updated•12 years ago
|
Whiteboard: [orange]
You need to log in
before you can comment on or make changes to this bug.
Description
•