443864 - Automate litmus test Testcase ID #4557 - Queued / "Starting ..." downloads

Status: NEW

(Toolkit :: Downloads API, defect)

Description

[Anoop Saldanha (Poona)]

Proposed type of test: xpcshell

Proposed location of test: Shawn, should I put this in the folder where we have out existing xpchsell dm tests?

Comment 1

[Shawn Wilsher :sdwilsh]

yes

Comment 2

[Anoop Saldanha (Poona)]

Attachment: v1.0

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 328328 [details] [diff] [review]
v1.0

>+ * Contributor(s):
>+ *  Anoop Saldanha<[e-mail]>
nit: one more space indentation please


>+ /* This test, tests bug 443864.  Basically this tests if setting
>+  * network.http.max-connections-per-server to 2, will result in any download
>+  * after the 2nd download, in a sequence of more than 2 downloads, being queued
>+  * in the dm than start downloading.
>+  */
nit: not the right format.


>+const Cc = Components.classes;
>+const Ci = Components.interfaces;
>+const Cr = Components.results;
You shouldn't have to declare these - they are in the head file

>+function cleanUp(let max_conn)
>+{
>+  dm.cancelDownload(dl[0]);
>+  dm.cancelDownload(dl[1]);
>+  dm.cancelDownload(dl[2]);
>+  
>+  dm.cleanUp();
>+  dmFile.remove(false);
>+  dm.DBConnection.executeSimpleSQL("DELETE FROM moz_downloads");
>+  // Reset the preference network.http.max-connections-per-server to initial value
>+  prefServ.setIntPref("network.http.max-connections-per-server", max_conn);
>+
>+  do_test_finished();
>+
>+  return
>+}
We already define a cleanup function in the head_ file...

Overall, you should copy the format of existing test files here.

Comment 4

[Anoop Saldanha (Poona)]

Attachment: v2.0

I haven't made any major structural change to the file, but I made the necessary corrections

Comment 5

[Anoop Saldanha (Poona)]

Attachment: v3.0

Comment 6

[Shawn Wilsher :sdwilsh]

Comment on attachment 329200 [details] [diff] [review]
v3.0

we are punting on this one for the time being

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.