Open Bug 443864 Opened 13 years ago Updated 13 years ago

Automate litmus test Testcase ID #4557 - Queued / "Starting ..." downloads

Categories

(Toolkit :: Downloads API, defect)

defect
Not set
normal

Tracking

()

ASSIGNED

People

(Reporter: poonaatsoc, Assigned: poonaatsoc)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file, 2 obsolete files)

Proposed type of test: xpcshell

Proposed location of test: Shawn, should I put this in the folder where we have out existing xpchsell dm tests?
yes
Attached patch v1.0 (obsolete) — Splinter Review
Attachment #328328 - Flags: review?(sdwilsh)
Comment on attachment 328328 [details] [diff] [review]
v1.0

>+ * Contributor(s):
>+ *  Anoop Saldanha<poonaatsoc@gmail.com>
nit: one more space indentation please


>+ /* This test, tests bug 443864.  Basically this tests if setting
>+  * network.http.max-connections-per-server to 2, will result in any download
>+  * after the 2nd download, in a sequence of more than 2 downloads, being queued
>+  * in the dm than start downloading.
>+  */
nit: not the right format.


>+const Cc = Components.classes;
>+const Ci = Components.interfaces;
>+const Cr = Components.results;
You shouldn't have to declare these - they are in the head file

>+function cleanUp(let max_conn)
>+{
>+  dm.cancelDownload(dl[0]);
>+  dm.cancelDownload(dl[1]);
>+  dm.cancelDownload(dl[2]);
>+  
>+  dm.cleanUp();
>+  dmFile.remove(false);
>+  dm.DBConnection.executeSimpleSQL("DELETE FROM moz_downloads");
>+  // Reset the preference network.http.max-connections-per-server to initial value
>+  prefServ.setIntPref("network.http.max-connections-per-server", max_conn);
>+
>+  do_test_finished();
>+
>+  return
>+}
We already define a cleanup function in the head_ file...

Overall, you should copy the format of existing test files here.
Attachment #328328 - Flags: review?(sdwilsh) → review-
Attached patch v2.0 (obsolete) — Splinter Review
I haven't made any major structural change to the file, but I made the necessary corrections
Attachment #328328 - Attachment is obsolete: true
Attachment #328482 - Flags: review?(sdwilsh)
Attached patch v3.0Splinter Review
Attachment #328482 - Attachment is obsolete: true
Attachment #329200 - Flags: review?(sdwilsh)
Attachment #328482 - Flags: review?(sdwilsh)
Comment on attachment 329200 [details] [diff] [review]
v3.0

we are punting on this one for the time being
Attachment #329200 - Flags: review?(sdwilsh)
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.