Closed Bug 444167 Opened 12 years ago Closed 12 years ago
Monkey's HTTP Networking preferences to new pref window
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:188.8.131.52) Gecko/20080328 SeaMonkey/1.1.9 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:184.108.40.206) Gecko/20080328 SeaMonkey/1.1.9 No need for much text here... Reproducible: Always
I want to take this one and publish a patch (even if this ... Bugzilla doesn't allow me to take the bug).
Assignee: nobody → Manuel.Spam
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → seamonkey2.0alpha
Version: unspecified → Trunk
We have set a deadline of September 9 to have all prefpanels done. If you can't have a patch ready for checkin or until for review within those two weeks, please unassign and find someone who can do the patch in time.
Comment on attachment 336715 [details] [diff] [review] First patch (Checkin: Comment 6) While we're here, I noticed some optional tweaks: >+ <hbox align="start"> I'm not sure that this align attribute is necessary. It only makes a difference in those localisations which have different amounts of text in the two groupboxes, and allows them to have a different height. In fact, replacing it with equalsize="true" to force them to have the same width too is tempting. >+ <groupbox flex="1"> >+ <caption label="&prefDirect.label;"/> >+ <vbox class="box-padded" >+ align="start"> I think it's better to have all attributes on the same line if they will fit. I didn't like the look of the two vboxes before either, and I'm thinking that perhaps we could switch them to use class="indent" instead.
Comment on attachment 336715 [details] [diff] [review] First patch (Checkin: Comment 6) >+ var enabled = (prefHTTPVersion.value == "1.1" && prefKeepAlive.value); May be worth setting a const for 1.1 and using it here and further down. >--- a/suite/common/pref/preferences.xul Mon Aug 25 00:03:44 2008 -0400 >+ <treeitem id="httpItem" label="&httpnetworking.label;" One attribute per line. >+ prefpane="http_pane" >+ helpTopic="advanced_http_networking" > url="chrome://communicator/content/pref/pref-http.xul"/>
Comment on attachment 336715 [details] [diff] [review] First patch (Checkin: Comment 6) Push made with attribute/class changes as per r/sr http://hg.mozilla.org/comm-central/rev/3251006d4f7f
Attachment #336715 - Attachment description: First patch → First patch (Checkin: Comment 6)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.