444174 - more readable/compact talos output to waterfall.

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[alice nodelman [:alice] [:anode]]

Goals:

- thinner talos columns on the waterfall
- easier to read output (convert memory sizes in bytes into easy to read MB or GB)

Comment 1

[alice nodelman [:alice] [:anode]]

Attachment: [checked in] allow waterfall to line break

Currently we force the waterfall to have test:value on the same line, making the waterfall column wider.  This patch allows for a line break between test and value.

You can see it up and running on the MozillaTest waterfall.

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 328546 [details] [diff] [review]
[checked in] allow waterfall to line break 

um, I'm not seeing an extra space in the second line, other than the space before the + operator. Is that right?

Also, didn't we get burned once before trying to add spaces and linebreaks on the tinderbox waterfall?

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 328546 [details] [diff] [review]
[checked in] allow waterfall to line break 

extra non-significant space in the second line not-withstanding, r+.

Comment 4

[alice nodelman [:alice] [:anode]]

Comment on attachment 328546 [details] [diff] [review]
[checked in] allow waterfall to line break 

Checking in run_tests.py;
/cvsroot/mozilla/testing/performance/talos/run_tests.py,v  <--  run_tests.py
new revision: 1.29; previous revision: 1.28
done

Comment 5

[alice nodelman [:alice] [:anode]]

Attachment: [Checked in]compact format for values measured in bytes

Had this floating around in stage for a good many months, time to get it rolled out.  Was initially waiting on ensuring that all memory related metrics are reported in bytes, and that got fixed quite a while ago as well.

Comment 6

[alice nodelman [:alice] [:anode]]

Comment on attachment 353735 [details] [diff] [review]
[Checked in]compact format for values measured in bytes

Checking in run_tests.py;
/cvsroot/mozilla/testing/performance/talos/run_tests.py,v  <--  run_tests.py
new revision: 1.34; previous revision: 1.33
done

Comment 7

[alice nodelman [:alice] [:anode]]

Pushed to production and looks good on the waterfall.