444218 - Show/Hide the Side Navigation Controls

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: v1 hides and shows the sidebar using F4

bug 436068 landed the basic urlbar and sidebar for navigation controls. The sidebar still needs to slide in & out as per design, but we need some underlying panning code to help implement that.

This bug is to allow the user to manually (without panning help) show and hide the sidebar controls using the F4 key (application menu hard button on the n8x0)

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 328578 [details] [diff] [review]
v1 hides and shows the sidebar using F4

>diff --git a/chrome/content/browser.js b/chrome/content/browser.js

>     switch (cmd) {
>+      case "cmd_menu":
>+        controls.collapsed = controls.collapsed ? false : true;

I find controls.collapsed = !controls.collapsed easier to read.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: v2 with review comments and a bugfix

Made review changes and found a bug

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

changeset:   44:15166cd856a8

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

verified with beta3