444296 - smbase -- depreciate the used of <ostream.h>

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Gilles J. Seguin]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9) Gecko/2008061712 Fedora/3.0-1.fc9 Firefox/3.0
Build Identifier: smbase current

implementation of c++ compiler now conform to standard.
and name in std libraries required "using namespace std;" declaration.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Gilles J. Seguin]

Attachment: diff file of the smbasee directory

Comment 2

[(dormant account)]

Comment on attachment 328642 [details] [diff] [review]
diff file of the smbasee directory

> #include <string.h>       // strlen, strcpy
>-#include <iostream.h>     // clog
>+//#include <iostream.h>     // clog
Please delete lines instead of commenting them out

>-#include <iostream.h>    // ostream
>+#if defined(__GNUC__) && __GNUC__ < 4
>+# include <iostream.h>   // ostream
>+#else
>+# include <iostream>
>+#endif

Don't worry about ifdefing these, just delete the .h part


Please resubmit patches with that cleaned up.

Comment 3

[Gilles J. Seguin]

(In reply to comment #2)
> Don't worry about ifdefing these, just delete the .h part
> 
> Please resubmit patches with that cleaned up.

resubmitting with the corrections

Comment 4

[Gilles J. Seguin]

Attachment: diff file of the smbase directory

Comment 5

[(dormant account)]

Comment on attachment 328821 [details] [diff] [review]
diff file of the smbase directory


> 
> // ------------------ BitwiseGrowArray --------------------
>@@ -121,19 +121,19 @@
> 
>   // shallow copy data from src to dest
>   static void copy(T *dest, T *src, size_t count) {
>-    memcpy(dest, src, sizeof(T)*count);
>+    ::memcpy(dest, src, sizeof(T)*count);
>   }
> 
>   // uninitialized alloc
>   static T *alloc(size_t count) {
>-    void *m = malloc(sizeof(T)*count);
>-    if (!m) throw bad_alloc();
>+    void *m = ::malloc(sizeof(T)*count);
>+    if (!m) throw std::bad_alloc();
>     return (T*) m;
>   }
> 
>   // dealloc
>   static void dealloc(T *ary) {
>-    free(ary);
>+    ::free(ary);
>   }
> };
> 

Is most of this really needed to compile?

Comment 6

[(dormant account)]

also, since these files aren't headers. Wouldn't it make more sense to just put using namespace std on top?

Comment 7

[(dormant account)]

nevermind, i guess the whole problem is that you can't do using namespace std;

Comment 8

[(dormant account)]

Hey Gilles,
I'm still on this. I think I want to work on the renaming tool so I can rename elsa's string class and do using namespace std; in .cpp files.

This way the code is a good testcase for it.

if you like I can compromise and commit .h changes now and you can maintain .cpp changes in your own patch queue for now. I don't think it'll take too long to do the rename.

Comment 9

[Gilles J. Seguin]

Attachment: smbase hg diff file, against current

Comment 10

[Gilles J. Seguin]

Attachment: hg diff file from smbase directory

should not depend on #331412 attachment.

Comment 11

[Gilles J. Seguin]

Attachment: hg diif file from smbase, for "make check"

Comment 12

[(dormant account)]

thanks, pushed