Closed
Bug 444307
Opened 16 years ago
Closed 16 years ago
Page Style functions cleanup
Categories
(Firefox :: Menus, defect)
Firefox
Menus
Tracking
()
RESOLVED
FIXED
Firefox 3.1a2
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
|
6.27 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
Array.some / Array.slice instead of for-loops, and some minor drive-by cleanup.
Attachment #328648 -
Flags: review?(gavin.sharp)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 328648 [details] [diff] [review] patch Can you write a test for this while you're at it? A browser chrome test that loads a page that references a bunch of stylesheets (ideally hitting as many of the code paths as possible), and then call stylesheetFillPopup and check that the menu is populated correctly, maybe? Similar to browser/base/content/test/browser_autodiscovery.js I guess.
Attachment #328648 -
Flags: review?(gavin.sharp) → review+
|
Assignee | |
Comment 2•16 years ago
|
||
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/page_style_sample.html?raw=1 http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/browser_page_style_menu.js
Flags: in-testsuite+
|
|
Assignee | |
Comment 3•16 years ago
|
||
These tests certainly don't cover everything, they are merely a start...
|
|
Assignee | |
Comment 4•16 years ago
|
||
http://hg.mozilla.org/index.cgi/mozilla-central/rev/e270d0ae94b7
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1a2
|
|
||
Comment 5•16 years ago
|
||
Thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•