444448 - Zooming within Print-Preview doesn't scale text inside of iframes

Status: RESOLVED FIXED

(Core :: Print Preview, defect)

Description

[Daniel Holbert [:dholbert]]

Steps to reproduce:
 1. Print-Preview testcase
 2. Zoom in or out (by holding Ctrl and scrolling mousewheel)

ACTUAL BEHAVIOR:
 - Page and iframe sizes scale correctly
 - Contents of iframe stay original size

EXPECTED BEHAVIOR: 
 - Contents of iframe should scale with the page.

(Testcase coming up.)

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9) Gecko/2008052912 Firefox/3.0

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Contents of iframe

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to comment #0)
> ACTUAL BEHAVIOR:
>  - Page and iframe sizes scale correctly
>  - Contents of iframe stay original size

One more thing -- the underline seem to scale correctly, too. (separate from the unscaled text that it is supposed to be underlining)  

This results in the underline being far off on its own, or overlapping other text, both of which look really bad.

Comment 4

[Daniel Holbert [:dholbert]]

(In reply to comment #3)
> One more thing -- the underline seem to scale correctly, too.

The same is true of strikethrough (with the <del> tag)

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: screenshot of bug (zoomed in)

Comment 6

[Daniel Holbert [:dholbert]]

Attachment: screenshot of bug (zoomed out)

Comment 7

[Daniel Holbert [:dholbert]]

Martijn says in IRC that he can reproduce this on Windows.
Hardware / OS --> All

Comment 8

[Daniel Holbert [:dholbert]]

Just tried to track down a regression range, and it looks like this has been broken ever since zooming started working in print-preview.

NO ZOOMING IN PRINT-PREV:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007110804 Minefield/3.0b2pre

ZOOMING ALLOWED IN PRINT-PREV, BUT WITH THIS BUG:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007110904 Minefield/3.0b2pre

Comment 9

[Daniel Holbert [:dholbert]]

It looks like print-preview-zooming was enabled in bug 363265, which was landed in the checkin range between by the nightlies mentioned in my previous comment.  Adding dependency.

Comment 10

[Daniel Holbert [:dholbert]]

Also, FWIW:
 -- before bug 363265 landed, print-preview would simply start at the zoomlevel that the browser was using before print-preview was invoked (and then disallows zooming during print-preview)
 -- after bug 363265 landed, print-preview starts at 100% zoom-level, regardless of what the zoom level was before it was invoked. (and then it allows you to zoom, with this bug)

Comment 11

[Daniel Holbert [:dholbert]]

See also bug 476841, which is basically the same as this bug but with <frame> instead of <iframe>.  It's probably a dupe, but I just marked it as a dependency for now.

That bug shows that images scale fine, too (in addition to underlines, as mentioned here in comment 3).  It's apparently just the text itself that doesn't zoom. Perhaps this happens because text-zoom might make us change fonts, and we aren't letting ourselves do that inside of iframes