Closed
Bug 444466
Opened 16 years ago
Closed 16 years ago
Crash [@ nsTextControlFrame::PreDestroy()]
Categories
(Core :: Layout: Form Controls, defect)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
mozilla1.9.1a1
People
(Reporter: neil, Assigned: neil)
Details
(Keywords: crash, fixed1.9.0.2)
Crash Data
Attachments
(1 file)
|
816 bytes,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
samuel.sidler+old
:
approval1.9.0.2+
|
Details | Diff | Splinter Review |
I've only seen this in a 1.9.0 Linux debug build, but the code is suspect.
|
Assignee | |
Comment 1•16 years ago
|
||
This fixes the crash for me.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #328769 -
Flags: superreview?(bzbarsky)
Attachment #328769 -
Flags: review?(bzbarsky)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 328769 [details] [diff] [review] Proposed patch Makes sense. Check in a crashtest too?
Attachment #328769 -
Flags: superreview?(bzbarsky)
Attachment #328769 -
Flags: superreview+
Attachment #328769 -
Flags: review?(bzbarsky)
Attachment #328769 -
Flags: review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
(In reply to comment #2) > Check in a crashtest too? I'd love to, but my crash trigger was closing a window, which we already test.
Keywords: checkin-needed
|
||
Comment 4•16 years ago
|
||
http://hg.mozilla.org/index.cgi/mozilla-central/rev/2b156d138832
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a1
|
|
Assignee | |
Comment 5•16 years ago
|
||
Comment on attachment 328769 [details] [diff] [review] Proposed patch Simple null-check for a potential crash.
Attachment #328769 -
Flags: approval1.9.0.2?
|
||
Comment 6•16 years ago
|
||
Comment on attachment 328769 [details] [diff] [review] Proposed patch Approved for 1.9.0.2. Please land in CVS. a=ss
Attachment #328769 -
Flags: approval1.9.0.2? → approval1.9.0.2+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: fixed1.9.0.2
|
||
Comment 7•16 years ago
|
||
Can we get STR to verify this bug? Thanks.
|
||
Updated•13 years ago
|
Crash Signature: [@ nsTextControlFrame::PreDestroy()]
You need to log in
before you can comment on or make changes to this bug.
Description
•