444487 - Extensions currently not included in WinCE XULRunner Build

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[John Wolfe (:wolfe)]

Attachment: Comment out building and including extensions for WinCE builds

WinCE does not use Extensions, so they should not be compiled or referenced in WinCE builds.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Why wouldn't we want the extension manager on WinCE? It's a pretty important part of our platform...

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #1)
> Why wouldn't we want the extension manager on WinCE? It's a pretty important
> part of our platform...
> 

Agreed

Comment 3

[John Wolfe (:wolfe)]

Doug, Brad, and I disabled Extensions to try to get XULRunner up and running initially.  After getting XULRunner working, then we can come back and make extensions work again.

Comment 4

[Dave Townsend [:mossop]]

What was not working with the extension manager enabled?

Comment 5

[Stuart Parmenter]

Comment on attachment 328794 [details] [diff] [review]
Comment out building and including extensions for WinCE builds

i'd rather not just disable extensions.  can we fix whatever was broken here?

Comment 6

[John Wolfe (:wolfe)]

Attachment: Same DIFF, just done in Unified instead of Context formatting

Comment 7

[John Wolfe (:wolfe)]

I just want to get something working first, then start adding in complexity.

Right now, we are having trouble getting startup and a single rendering working - so this patch is a temporary fix for any developers who want to play around with Windows Mobile builds.  It does not have to be landed, I suppose, but just serve as a place marker so that we remember to re-enable extensions and debug them before declaring victory on creating a functional XULRunner.exe

Comment 8

[Stuart Parmenter]

Comment on attachment 329596 [details] [diff] [review]
Same DIFF, just done in Unified instead of Context formatting

I agree that what you've done is a good starting point, but I don't think it should land on mozilla-central in this early state.

Comment 9

[Dave Townsend [:mossop]]

If there is an actual problem with the extension manager in WinCE then please file that and we can figure out how to fix it. Without any knowledge of the problems though we aren't going to just disable it by default.

Comment 10

[John Wolfe (:wolfe)]

Attachment: Same patch file, updated to work against mozilla-central repository

This patch is submitted for WinMobile developers who want to turn off extensions temporarily.