Closed Bug 444492 Opened 12 years ago Closed 12 years ago

Cairo _get_system_quality() function stubbed out in WinCE

Categories

(Core :: Graphics, defect)

x86
Windows CE
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.1a2

People

(Reporter: wolfe, Assigned: wolfe)

References

Details

(Keywords: mobile)

Attachments

(1 file, 2 obsolete files)

No ClearType or FontSmoothing in WinCE builds yet.  Stubbed out so _get_system_quality() always returns DEFAULT_QUALITY.
Component: General → GFX: Thebes
Product: Fennec → Core
QA Contact: general → thebes
Version: 1.0 → Trunk
Keywords: mobile
Comment on attachment 328799 [details] [diff] [review]
_get_system_quality() Returns DEFAULT_QUALITY on WinCE

do we have a WINCE define in cairo?
Attachment #328799 - Flags: review?(vladimir)
Attachment #328799 - Attachment is obsolete: true
Attachment #328799 - Flags: review?(vladimir)
WINCE is defined during the WinCE building, and is defined for ALL source code built to target WinCE.  Otherwise, WINCE is never defined (as far as I know).
Comment on attachment 329599 [details] [diff] [review]
Same DIFF, just done in Unified instead of Context formatting

I removed the review flag when updating DIFF CONTEXT patch to be DIFF UNIFIED.  Sorry for the confusion.
Attachment #329599 - Flags: review?(vladimir)
Comment on attachment 329599 [details] [diff] [review]
Same DIFF, just done in Unified instead of Context formatting

This is fine, but it needs to get checked in upstream.  If it gets checked in to our repo first, then make sure to add it to gfx/cairo/README and a patch file in gfx/cairo.
Attachment #329599 - Flags: review?(vladimir) → review+
Keywords: checkin-needed
Assignee: nobody → wolfe
Blocks: 432792
Pushed as 17100:59a60321d0d6.
Status: NEW → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a2
Ugh, I just saw comment #5. If you want this landed in mozilla-central, please attach a patch that includes the requirements vlad says in comment #5.

Backed out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Added comment into README, added patch file into gfx/cairo.  Vladimir, can you check that I did the patch-file-in-the-patch-file correctly?
Attachment #329599 - Attachment is obsolete: true
Attachment #337360 - Flags: review?(vladimir)
Comment on attachment 337360 [details] [diff] [review]
Patch with README / cairo patch file now included

Yep, looks great, thanks!  I'll get it checked into upstream cairo next time I do an update (which should be soonish).
Attachment #337360 - Flags: review?(vladimir) → review+
Added checkin-needed flag to this bug.
Keywords: checkin-needed
Comment on attachment 337360 [details] [diff] [review]
Patch with README / cairo patch file now included

Patch fails to apply to m-c.
Patch was landed (by Vladimir?) already - I just updated my mozilla-central to verify.

Serge, I am really sorry that you had to waste some time with trying to apply this patch.  I must have mis-understood Vladimir (or someone else).
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Whoops, yeah, sorry -- I pulled this in when I did a cairo upgrade and forgot to close the bug.
You need to log in before you can comment on or make changes to this bug.