444492 - Cairo _get_system_quality() function stubbed out in WinCE

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[John Wolfe (:wolfe)]

Attachment: _get_system_quality() Returns DEFAULT_QUALITY on WinCE

No ClearType or FontSmoothing in WinCE builds yet.  Stubbed out so _get_system_quality() always returns DEFAULT_QUALITY.

Comment 1

[Stuart Parmenter]

Comment on attachment 328799 [details] [diff] [review]
_get_system_quality() Returns DEFAULT_QUALITY on WinCE

do we have a WINCE define in cairo?

Comment 2

[John Wolfe (:wolfe)]

Attachment: Same DIFF, just done in Unified instead of Context formatting

Comment 3

[John Wolfe (:wolfe)]

WINCE is defined during the WinCE building, and is defined for ALL source code built to target WinCE.  Otherwise, WINCE is never defined (as far as I know).

Comment 4

[John Wolfe (:wolfe)]

Comment on attachment 329599 [details] [diff] [review]
Same DIFF, just done in Unified instead of Context formatting

I removed the review flag when updating DIFF CONTEXT patch to be DIFF UNIFIED.  Sorry for the confusion.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 329599 [details] [diff] [review]
Same DIFF, just done in Unified instead of Context formatting

This is fine, but it needs to get checked in upstream.  If it gets checked in to our repo first, then make sure to add it to gfx/cairo/README and a patch file in gfx/cairo.

Comment 6

[Reed Loden [:reed]]

Pushed as 17100:59a60321d0d6.

Comment 7

[Reed Loden [:reed]]

Ugh, I just saw comment #5. If you want this landed in mozilla-central, please attach a patch that includes the requirements vlad says in comment #5.

Backed out.

Comment 8

[John Wolfe (:wolfe)]

Attachment: Patch with README / cairo patch file now included

Added comment into README, added patch file into gfx/cairo.  Vladimir, can you check that I did the patch-file-in-the-patch-file correctly?

Comment 9

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 337360 [details] [diff] [review]
Patch with README / cairo patch file now included

Yep, looks great, thanks!  I'll get it checked into upstream cairo next time I do an update (which should be soonish).

Comment 10

[John Wolfe (:wolfe)]

Added checkin-needed flag to this bug.

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 337360 [details] [diff] [review]
Patch with README / cairo patch file now included

Patch fails to apply to m-c.

Comment 12

[John Wolfe (:wolfe)]

Patch was landed (by Vladimir?) already - I just updated my mozilla-central to verify.

Serge, I am really sorry that you had to waste some time with trying to apply this patch.  I must have mis-understood Vladimir (or someone else).

Comment 13

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Whoops, yeah, sorry -- I pulled this in when I did a cairo upgrade and forgot to close the bug.