Closed Bug 444494 Opened 12 years ago Closed 11 years ago

GlobalWindow Activation Events Sometimes Missed in WinCE

Categories

(Core :: DOM: Core & HTML, defect)

x86
Windows CE
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: wolfe, Assigned: wolfe)

References

Details

(Keywords: mobile)

Attachments

(1 file, 2 obsolete files)

Need to patch around missing GlobalWindow activation events because we do not have WM_ACTIVATEAPP and WM_MOUSEACTIVATE windows messages in WinCE
Component: General → DOM
Product: Fennec → Core
QA Contact: general → general
Version: 1.0 → Trunk
Keywords: mobile
Comment on attachment 328801 [details] [diff] [review]
Patch Around Missing ActiveApp and MouseActivate Messages in WinCE (Possibly Not Complete Patch Yet)

bkap can you look at this and provide some suggestions?
Attachment #328801 - Flags: review?(mrbkap)
jst should really take a look at this.

In general, if a given platform doesn't dispatch an event, I think we generally try to synthesize that event where possible (see, for example, NS_ACTIVATE/NS_GOTFOCUS).
This looks like Smaug territory.
Comment on attachment 329600 [details] [diff] [review]
Same DIFF, just done in Unified instead of Context formatting

I mistakenly removed the review request when updating the attachment from DIFF CONTEXT to DIFF UNIFIED.  Sorry for the confusion.
Attachment #329600 - Flags: review?(mrbkap)
Attachment #329600 - Flags: review?(mrbkap) → review?(Olli.Pettay)
So WinCE widgets don't dispatch NS_ACTIVATE/DEACTIVATE? Is NS_GOTFOCUS dispatched?
Or NS_LOSTFOCUS?

http://mxr.mozilla.org/mozilla-central/source/widget/src/windows/nsWindow.cpp#4721
http://mxr.mozilla.org/mozilla-central/source/widget/src/windows/nsWindow.cpp#4763

To me this seems so a widget level bug, agreeing with comment 2.
Comment on attachment 329600 [details] [diff] [review]
Same DIFF, just done in Unified instead of Context formatting

I really wouldn't like to have this kinds of hacks, unless nothing else works.
Attachment #329600 - Flags: review?(Olli.Pettay) → review-
Ere, do you know anything about WinCE?
Not really. dougt might be the one..
john, can you give us some background here.
Assignee: nobody → wolfe
Blocks: 432792
Sure - this patch was supplied to me by Brad Lassey earlier this year.  It was an attempt to fix XULRunner main windows not coming to the foreground when starting XULRunner.  

The actual bug causing second and subsequent windows to not appear correctly under WinCE was somewhere else in the code.

However, I do not yet have a build which lets me verify that these patches are not necessary for proper XULRunner operation.  Until I do have a functional XULRunner build, and can verify things one way or the other, I would like to leave this bug open.
Fixed in code checked in by Doug and/or Brad last fall.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.