444494 - GlobalWindow Activation Events Sometimes Missed in WinCE

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[John Wolfe (:wolfe)]

Attachment: Patch Around Missing ActiveApp and MouseActivate Messages in WinCE (Possibly Not Complete Patch Yet)

Need to patch around missing GlobalWindow activation events because we do not have WM_ACTIVATEAPP and WM_MOUSEACTIVATE windows messages in WinCE

Comment 1

[Stuart Parmenter]

Comment on attachment 328801 [details] [diff] [review]
Patch Around Missing ActiveApp and MouseActivate Messages in WinCE (Possibly Not Complete Patch Yet)

bkap can you look at this and provide some suggestions?

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

jst should really take a look at this.

In general, if a given platform doesn't dispatch an event, I think we generally try to synthesize that event where possible (see, for example, NS_ACTIVATE/NS_GOTFOCUS).

Comment 3

[John Wolfe (:wolfe)]

Attachment: Moves handling changes for WM_ACTIVATEAPP and WM_MOUSEACTIVATE into this bug from bug # 444488

Comment 4

[Johnny Stenback (:jst)]

This looks like Smaug territory.

Comment 5

[John Wolfe (:wolfe)]

Attachment: Same DIFF, just done in Unified instead of Context formatting

Comment 6

[John Wolfe (:wolfe)]

Comment on attachment 329600 [details] [diff] [review]
Same DIFF, just done in Unified instead of Context formatting

I mistakenly removed the review request when updating the attachment from DIFF CONTEXT to DIFF UNIFIED.  Sorry for the confusion.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

So WinCE widgets don't dispatch NS_ACTIVATE/DEACTIVATE? Is NS_GOTFOCUS dispatched?
Or NS_LOSTFOCUS?

http://mxr.mozilla.org/mozilla-central/source/widget/src/windows/nsWindow.cpp#4721
http://mxr.mozilla.org/mozilla-central/source/widget/src/windows/nsWindow.cpp#4763

To me this seems so a widget level bug, agreeing with comment 2.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 329600 [details] [diff] [review]
Same DIFF, just done in Unified instead of Context formatting

I really wouldn't like to have this kinds of hacks, unless nothing else works.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Ere, do you know anything about WinCE?

Comment 10

[Ere Maijala (slow)]

Not really. dougt might be the one..

Comment 11

[Doug Turner (:dougt)]

john, can you give us some background here.

Comment 12

[John Wolfe (:wolfe)]

Sure - this patch was supplied to me by Brad Lassey earlier this year.  It was an attempt to fix XULRunner main windows not coming to the foreground when starting XULRunner.  

The actual bug causing second and subsequent windows to not appear correctly under WinCE was somewhere else in the code.

However, I do not yet have a build which lets me verify that these patches are not necessary for proper XULRunner operation.  Until I do have a functional XULRunner build, and can verify things one way or the other, I would like to leave this bug open.

Comment 13

[John Wolfe (:wolfe)]

Fixed in code checked in by Doug and/or Brad last fall.