Closed Bug 444532 Opened 15 years ago Closed 15 years ago

Select 'Convert to->Task/event' in the preview pane in mailmode causes an uncaught exception

Categories

(Calendar :: Lightning Only, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: andreas.treumann, Assigned: Fallen)

Details

Attachments

(1 file, 2 obsolete files)

STEPS TO REPRODUCE:
===================

- go to the mailmode
- don't select anything
- open the context menu and select 'Convert to -> Event/Task'

RESULT:
=======

- error console shows:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIMessenger.msgHdrFromURI]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://messenger/content/messenger.xul :: oncommand :: line 1"  data: no] 

EXPECTED RESULT:
================

- no error console output
REPRODUCIBLE:
=============

- always
for a better reproducibility:

step 3 of the STR should be:

- open the context menu in the preview pane and select 'Convert to -> Event/Task'

Summary: Select 'Convert to->Task/event' in the preview pain in mailmode causes an uncaught exception → Select 'Convert to->Task/event' in the preview pane in mailmode causes an uncaught exception
for a better reproducibility:

step 3 of the STR should be:

- open the context menu in the preview pane and select 'Convert to -> Event/Task'

Flags: blocking-calendar0.9+
Attached patch Fix - v1 (obsolete) β€” β€” Splinter Review
Assignee: Berend.Cornelius → philipp
Status: NEW → ASSIGNED
Attachment #333061 - Flags: review?(daniel.boelzle)
Attached patch Fix - v1.1 (obsolete) β€” β€” Splinter Review
Attachment #333061 - Attachment is obsolete: true
Attachment #333062 - Flags: review?(daniel.boelzle)
Attachment #333061 - Flags: review?(daniel.boelzle)
Whiteboard: [patch in hand] [needs-review]
Comment on attachment 333062 [details] [diff] [review]
Fix - v1.1

This disables the "Convert To" menu item. I'd rather think we should remove the menu item in those cases like any other mail-content menu items disappear, too.
Attachment #333062 - Flags: review?(daniel.boelzle) → review-
Whiteboard: [patch in hand] [needs-review]
Attached patch Fix - v2 β€” β€” Splinter Review
While I agree with the message pane, I don't with the thread pane. In the thread pane, the items are disabled, in the message pane they are gone.
Attachment #333062 - Attachment is obsolete: true
Attachment #333304 - Flags: review?(daniel.boelzle)
Comment on attachment 333304 [details] [diff] [review]
Fix - v2

works fine, looks good; r=dbo
Attachment #333304 - Flags: review?(daniel.boelzle) → review+
Whiteboard: [patch in hand]
Keywords: checkin-needed
Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [patch in hand]
Target Milestone: --- → 0.9
Checked in lightning 2008081803 -> VERIFIED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.