444532 - Select 'Convert to->Task/event' in the preview pane in mailmode causes an uncaught exception

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Andreas Treumann]

STEPS TO REPRODUCE:
===================

- go to the mailmode
- don't select anything
- open the context menu and select 'Convert to -> Event/Task'

RESULT:
=======

- error console shows:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIMessenger.msgHdrFromURI]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://messenger/content/messenger.xul :: oncommand :: line 1"  data: no] 

EXPECTED RESULT:
================

- no error console output
REPRODUCIBLE:
=============

- always

Comment 1

[Andreas Treumann]

for a better reproducibility:

step 3 of the STR should be:

- open the context menu in the preview pane and select 'Convert to -> Event/Task'

Comment 2

[Andreas Treumann]

for a better reproducibility:

step 3 of the STR should be:

- open the context menu in the preview pane and select 'Convert to -> Event/Task'

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1.1

Comment 5

[Daniel Boelzle [:dbo]]

Comment on attachment 333062 [details] [diff] [review]
Fix - v1.1

This disables the "Convert To" menu item. I'd rather think we should remove the menu item in those cases like any other mail-content menu items disappear, too.

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v2

While I agree with the message pane, I don't with the thread pane. In the thread pane, the items are disabled, in the message pane they are gone.

Comment 7

[Daniel Boelzle [:dbo]]

Comment on attachment 333304 [details] [diff] [review]
Fix - v2

works fine, looks good; r=dbo

Comment 8

[Daniel Boelzle [:dbo]]

Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED.

Comment 9

[Andreas Treumann]

Checked in lightning 2008081803 -> VERIFIED