444616 - TT: warning fixup for GCC4.3

Status: VERIFIED INCOMPLETE

(Tamarin Graveyard :: Build Config, defect)

Description

[Benjamin Smedberg]

Attachment: Aliasing and parens fixup for TT, rev. 1

This fixes two classes of warnings in TT:

-wparentheses - forces you to parenthesize expressions like foo && bar || baz because many people don't realize that && binds tighter than || (also & and |).

strict-aliasing. There's one warning where we're doing pointer math but really only need to do a const_cast.

Also at some point -Werror got turned off for TT. This turns it back on.

Comment 1

[Steven Johnson]

Comment on attachment 328933 [details] [diff] [review]
Aliasing and parens fixup for TT, rev. 1

Is there any way we can enable a similar warning in MSVC, to forestall cross-platform build breakage tweaks?

Comment 2

[Benjamin Smedberg]

Turns out this patch breaks other platforms in odd ways, so I haven't landed it.

I don't think MSVC has an equivalent warning class to -wparentheses, or at least doesn't warn about the same things.

Comment 3

[Edwin Smith]

ever figure out what the breakages were?  otherwise this is a candidate for WONTFIX

Comment 4

[Benjamin Smedberg]

No, I don't recall. I don't think this is WONTFIX, though it may be INCOMPLETE until somebody else comes along who cares.

Comment 5

[Chris Peyer]

Closing out all TT: transfer bugs that are resolved fixed.