444772 - Merge nsIKBStateControl into nsIWidget

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: patch 1.0 (Windows and Linux compiled/tested)

Merging nsIKBStateControl into nsIWidget makes it easier for each platform to implement the IME related methods.

I compiled and tested the first patch on Windows and Linux, but I don't have the environment for Mac OS X (or Photon) which I also changed code for.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

If you think you're ready to ask for review, request review (from me I guess). If it looks good I'll land it for you and I can check that it builds on Mac then.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 329090 [details] [diff] [review]
patch 1.0 (Windows and Linux compiled/tested)

OK, thanks. I think it's ready for review.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed 6692da1caef5. Thanks!!!

Comment 4

[[e-mail]]

Comment on attachment 329090 [details] [diff] [review]
patch 1.0 (Windows and Linux compiled/tested)

>   nsCOMPtr<nsIWidget> widget;
>   res = GetEditorContentWindow(shell, GetRoot(), getter_AddRefs(widget));
>   if (NS_FAILED(res))
>     return res;
>+  if (!widget)
>+    return NS_ERROR_NOT_AVAILABLE;
>+
>+  NS_ADDREF(*aWidget = widget);
> 
>   return NS_OK;

You could save an addref using widget.swap(*aWidget);

Or why not return GetEditorContentWindow(shell, GetRoot(), aWidget);