444805 - Pork: Figure out why testsuite fails

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[(dormant account)]

I wasn't aware i changed any pork code, so it's not amusing that it fails.

Will need to do some painful bisection(who came up with brilliant idea of using a bazillion repositories for coupled code).

Comment 1

[(dormant account)]

elsa_tests.gen.incl.mk <-- this file is pure evil. Mainstream oink maintains a committed version of it that is older than the one we imported(this is something version control geeks can try to figure out). Neither oink, nor pork worked with an up-to-date file . 
I disabled certain pointless tests, now the testsuite passes.

Comment 2

[Gilles J. Seguin]

Attachment: hg diff file oink/elsa_tests.gen.incl.mk

would prefer a less drastic cut instead of
changeset 712 to allow "make check" to succeed.

Comment 3

[(dormant account)]

(In reply to comment #2)
> Created an attachment (id=333409) [details]
> hg diff file oink/elsa_tests.gen.incl.mk
> 
> would prefer a less drastic cut instead of
> changeset 712 to allow "make check" to succeed.
> 

It's not drastic. Your proposed solution prevents the specific testcases from running..
My fix is that way it is because they are needed for parse testing with oink.  qual was never intended to be run on them.