Pork: Figure out why testsuite fails

RESOLVED FIXED

Status

RESOLVED FIXED
10 years ago
7 months ago

People

(Reporter: taras.mozilla, Unassigned)

Tracking

Trunk
x86
All

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
I wasn't aware i changed any pork code, so it's not amusing that it fails.

Will need to do some painful bisection(who came up with brilliant idea of using a bazillion repositories for coupled code).
(Reporter)

Comment 1

10 years ago
elsa_tests.gen.incl.mk <-- this file is pure evil. Mainstream oink maintains a committed version of it that is older than the one we imported(this is something version control geeks can try to figure out). Neither oink, nor pork worked with an up-to-date file . 
I disabled certain pointless tests, now the testsuite passes.

Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 2

10 years ago
Created attachment 333409 [details] [diff] [review]
hg diff file oink/elsa_tests.gen.incl.mk

would prefer a less drastic cut instead of
changeset 712 to allow "make check" to succeed.
(Reporter)

Comment 3

10 years ago
(In reply to comment #2)
> Created an attachment (id=333409) [details]
> hg diff file oink/elsa_tests.gen.incl.mk
> 
> would prefer a less drastic cut instead of
> changeset 712 to allow "make check" to succeed.
> 

It's not drastic. Your proposed solution prevents the specific testcases from running..
My fix is that way it is because they are needed for parse testing with oink.  qual was never intended to be run on them.

Updated

7 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.