444922 - Application Details empty after fixing empty Applications panel (after bug #409192)

Status: RESOLVED FIXED

(Firefox :: Preferences, defect)

Description

[Matt VanEseltine]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9) Gecko/2008070602 (Gentoo) Firefox/3.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9) Gecko/2008070602 (Gentoo) Firefox/3.0

After installing Firefox 3.0 (via masked Gentoo official ebuild) without Gnome libs, bug #409192 arose: an empty Applications panel.  I recompiled with the patch fixing #409192 to repopulate the applications list, and this was successful.  However, when "Application Details" is selected from a content type's dropdown, the list is empty.

Reproducible: Always

Steps to Reproduce:
1. Install 3.0 in a Linux environment without Gnome, producing bug #409192, empty Applications panel.
2. Recompile with patch to fix bug #409192.
3. Select Application Details from an Action dropdown in the Applications prefpane. (Web Feed is a good example since it comes with 3 actions pre-installed: Bloglines, My Yahoo, and Google.  These should be listed.)
Actual Results:  
Application Details list is empty.

Expected Results:  
Applications Details list displays some number of associated applications and an option to remove each.

Firefox produces no error messages or warnings to the console.  Profile is irrelevant. I don't funroll-loops, promise.

Comment 1

[Mike Hommey [:glandium]]

Attachment: patch

Actually, though i thought it was unrelated, this is due to the patch in bug 409192: getShellService is defined in utilityOverlay.js, which, while it is available in applications.xul through preferences.xul, is not in applicationManager.xul.

Comment 2

[Reed Loden [:reed]]

Comment on attachment 329238 [details] [diff] [review]
patch

Drivers, needed to fix a regression from bug 409192.

Comment 3

[Reed Loden [:reed]]

Pushed in 15890:a5d6a6d52eca.

Comment 4

[Samuel Sidler (old account; do not CC)]

Comment on attachment 329238 [details] [diff] [review]
patch

Approved for 1.9.0.2. Please land in CVS. a=ss

We should really have a test for this...

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #4)
> We should really have a test for this...

That would require a testbox without gnome libs, which isn't really a supported configuration. The alternative is a simulated test that makes the shell service throw intentionally, but I don't really think that's worth the trouble.

The distros that support these configs should ideally be running our unit tests (http://www.0xdeadbeef.com/weblog/?p=371).

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Oh, except this bug was a regression from bug 409192 that affects all configs. Would be nice to get a test, then, yeah.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/preferences/applicationManager.xul 	1.4 

Comment 8

[Al Billings [:abillings - ex-MoCo]]

Matt, can you verify the fix with the 1.9.0.2 candidate build at ftp://ftp.mozilla.org/pub/firefox/nightly/3.0.2-candidates/build5/?