445000 - No tooltip for folders on bookmark toolbar

Status: NEW

(Firefox :: Bookmarks & History, enhancement, P5)

Description

[Kadir Topal [:atopal]]

If you add a folder with a long title to the bookmark toolbar it will be clipped (with ellipsses), but no tooltip will be shown. So you have no way to see what's the name of the folder. 

Note: this is on Mac, Windows is fine.

Comment 2

[Steven Michaud [:smichaud] (Retired)]

I can't reproduce what you report.

None of the *folders* on the Bookmarks toolbar have tooltips, even
those with very short names (e.g. "Smart Bookmarsks" and "Places").
This is true on OS X, Windows and Linux (and in both FF3 and FF2).

But if you create a *bookmark* on the Bookmarks toolbar that has a
very long name (one long enough for its name to be clipped where it's
displayed on the Bookmarks toolbar), the bookmark still has a tooltip,
and the entire name does still appear in the tooltip.

Comment 3

[Kadir Topal [:atopal]]

Steven, I was only speaking about folders anyway. But you are right, this is a cross plattform bug, not Mac only, I must have missed something when testing on windows.

Comment 4

[Gabriele Best [:Gabri]]

this is fixed with bug 237592 patch

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to comment #4)
> this is fixed with bug 237592 patch

mh, i can't see tooltips for folders on bookmarks toolbar on mac, anyone?

Comment 6

[Gabriele Best [:Gabri]]

bug 237592 doesn't fix this bug anymore.
See this https://bugzilla.mozilla.org/show_bug.cgi?id=237592#c102.

Comment 7

[Gabriele Best [:Gabri]]

Attachment: patch

Here the patch for this bug

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

imho the tooltip should be visible only if folder name is cropped

Comment 9

[Gabriele Best [:Gabri]]

You are right but I didn't found a way to do it :(

Comment 10

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

see also https://bugzilla.mozilla.org/show_bug.cgi?id=237592#c116

Comment 11

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

issues with drag&drop and tooltips appear fixed currently so if we want we can go on with this.

Comment 13

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Gabriele, does this work for livemark containers too?

Comment 14

[Dietrich Ayala (:dietrich)]

would take a patch for this once comment #8 is fixed.

Comment 15

[Gabriele Best [:Gabri]]

I don't think it's possible to show the tooltip only if folder name is cropped.

Comment 16

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

i'm not sure if makes much sense having a tooltip for folders at this point... 

probably would be good having a tooltip on livemark containers showing the siteURI/feedURI, but that could be not perf-friendly...
for sure we could add one to the Open <siteURI> options inside a live bookmark, since the uri is not visible elsewhere and the uri is not showed in statusbar.

Comment 17

[Kadir Topal [:atopal]]

Marco, why wouldn't it make sense? Right now there is no way to see the name of a folder on the bookmark toolbar if it's name is too long.

Comment 18

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

the tooltip is mostly useful on uri nodes to show the uri that would be not visible. on folders we really would need only for cropped ones, but detecting crop is not possible actually (or possible but with major hacks), and having tooltips on short folder names (the vast majority) looks bad (to me).

Hwv my comment was mostly for the missin tooltip on the open <siteURI>, i'll probably file a new bug for that since looks something we really need.

Comment 19

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

filed bug 476838

Comment 20

[Kadir Topal [:atopal]]

Okay, "looking bad" might be an argument, but "long names are useless" is the other one.

Comment 21

[Dão Gottwald [:dao]]

Comment on attachment 343229 [details] [diff] [review]
patch

looks like this has an implicit r- from comment 14

Comment 22

[Gabriele Best [:Gabri]]

Attachment: Patch only for cropped folders

Comment 23

[Gabriele Best [:Gabri]]

This patch needs landing of bug 514763

Comment 24

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 399714 [details] [diff] [review]
Patch only for cropped folders

clearing review request since we can't apply this now, please reask for review once we have a cropped attribute/property to use. Thanks.

Comment 25

[Gabriele Best [:Gabri]]

Attachment: Patch, v2.0

Comment 26

[Mark Banner (:standard8)]

I'm assuming Gabriele is no longer working on this.