445010 - Migrate MailNews Junk Mail to the new prefwindow

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Ian Neal]

Comment 1

[Ian Neal]

Attachment: pref-junk patch v0.1 (Checkin: Comment 4)

Comment 2

[[e-mail]]

Comment on attachment 329352 [details] [diff] [review]
pref-junk patch v0.1 (Checkin: Comment 4)

> function Startup()
> {
>+  UpdateDependentElement("manualMark", "manualMarkMode");
>+  UpdateDependentElement("enableJunkLogging", "openJunkLog");
> }
> 
>+function UpdateDependentElement(aBaseId, aDependentId)
> {
>+  var pref = document.getElementById(aBaseId).getAttribute("preference");
>+  EnableElementById(aDependentId, document.getElementById(pref).value, false);
> }
Since you know the preference attribute for both the manualMark and enableJunkLogging elements, you could pass in the pref id directly. You could even call EnableElementById directly i.e. EnableElementById("manualMarkMode", document.getElementById("mail.spam.manualMark").value, false); but I guess that's a little unwieldy.

Comment 3

[[e-mail]]

Comment on attachment 329352 [details] [diff] [review]
pref-junk patch v0.1 (Checkin: Comment 4)

Stealing Mnyromyr's review (with his permission).

Comment 4

[Ian Neal]

Comment on attachment 329352 [details] [diff] [review]
pref-junk patch v0.1 (Checkin: Comment 4)

http://hg.mozilla.org/comm-central/index.cgi/rev/647ef8ec4896