Migrate MailNews Junk Mail to the new prefwindow

RESOLVED FIXED

Status

SeaMonkey
Preferences
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
 
(Assignee)

Comment 1

10 years ago
Created attachment 329352 [details] [diff] [review]
pref-junk patch v0.1 (Checkin: Comment 4)
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #329352 - Flags: superreview?(neil)
Attachment #329352 - Flags: review?(mnyromyr)

Comment 2

10 years ago
Comment on attachment 329352 [details] [diff] [review]
pref-junk patch v0.1 (Checkin: Comment 4)

> function Startup()
> {
>+  UpdateDependentElement("manualMark", "manualMarkMode");
>+  UpdateDependentElement("enableJunkLogging", "openJunkLog");
> }
> 
>+function UpdateDependentElement(aBaseId, aDependentId)
> {
>+  var pref = document.getElementById(aBaseId).getAttribute("preference");
>+  EnableElementById(aDependentId, document.getElementById(pref).value, false);
> }
Since you know the preference attribute for both the manualMark and enableJunkLogging elements, you could pass in the pref id directly. You could even call EnableElementById directly i.e. EnableElementById("manualMarkMode", document.getElementById("mail.spam.manualMark").value, false); but I guess that's a little unwieldy.
Attachment #329352 - Flags: superreview?(neil) → superreview+

Comment 3

10 years ago
Comment on attachment 329352 [details] [diff] [review]
pref-junk patch v0.1 (Checkin: Comment 4)

Stealing Mnyromyr's review (with his permission).
Attachment #329352 - Flags: review?(mnyromyr) → review+
(Assignee)

Updated

10 years ago
Depends on: 448107
(Assignee)

Comment 4

10 years ago
Comment on attachment 329352 [details] [diff] [review]
pref-junk patch v0.1 (Checkin: Comment 4)

http://hg.mozilla.org/comm-central/index.cgi/rev/647ef8ec4896
Attachment #329352 - Attachment description: pref-junk patch v0.1 → pref-junk patch v0.1 (Checkin: Comment 4)
(Assignee)

Updated

10 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.