Closed Bug 445013 Opened 12 years ago Closed 12 years ago

Migrate SeaMonkey SSL to the new prefwindow

Categories

(SeaMonkey :: Preferences, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: iann_bugzilla, Assigned: philip.chee)

References

Details

Attachments

(1 file, 2 obsolete files)

 
I have a patch for this, but I wonder if we should start with sorting out source/security/manager/pki/resources/jar.mn. Afaik SeaMonkey is the only consumer of the following xul files:
PrefOverlay.xul, pref-ssl.xul, pref-certs.xul, pref-masterpass.xul, pref-validation.xul and PageInfoOverlay.xul (haven't looked at the .js files, but that should be easy to sort out). All those files (except for PageInfoOverlay.xul which is not packaged by Firefox) are atm packaged by all apps.

I was thinking that we put those files inside a ifdef MOZ_SUITE block. Does that sounds reasonable?
Yes, but the proof is in the pudding as they say ;)
Actually, we should move the suite-specific files to comm-central/suite.
Depends on: 450257
fyi, I won't be able to get to this until middle/end of september (and I seem to have lost the patch).
We have set a deadline of September 9 to have all prefpanels done. If you can't have a patch ready for checkin or until for review within those two weeks, please try to forward it to someone who can do the patch in time.
I have a WIP patch
Assignee: nobody → philip.chee
This fixes the SSL pane and also the Certificates pane (Bug 445014)

+function enableButton(button)
+{
+  var pref = document.getElementById(button.getAttribute("preference")).value;
+  pref = (pref == null) ? true : pref;
+  button.disabled = !pref;
+  return pref;
+}

Ideally I'd like to move this into preferences.js so that I can reuse this in the Validation and Passwords panes.
Attachment #336823 - Flags: review?(iann_bugzilla)
Comment on attachment 336823 [details] [diff] [review]
convert pref-ssl.xul and pref-certs.xul to prefpanes

>--- a/suite/security/prefs/pref-certs.js
>+function Startup()
No Startup function needed as onsync is not need here, see later.

>+function enableButton(button)
Not needed, see later.

> function openCertManager()
Nit: Capital letter at the start of a function name.

> function openDeviceManager()
Nit: Capital letter at the start of a function name.

>--- a/suite/security/prefs/pref-certs.xul
>+      <preference id="security.disable_button.openCertManager"
>+                  name="security.disable_button.openCertManager"
>+                  type="bool"
>+                  inverted="true"/>
In the new pref panel world disable_button prefs disable buttons when they are locked, the value of the pref makes no difference. So inverted attribute is not needed.
>+      <preference id="security.disable_button.openDeviceManager"
>+                  name="security.disable_button.openDeviceManager"
>+                  type="bool"
>+                  inverted="true"/>
See above.

>+      <radio label="&certselect.auto;"
>+             accesskey="&certselect.auto.accesskey;"
>+             value="Select Automatically"/>
Nit: value as first attribute please.
>+      <radio label="&certselect.ask;"
>+             accesskey="&certselect.ask.accesskey;"
>+             value="Ask Every Time"/>
Nit: value as first attribute please.

>       <button label="&managecerts.button;"
>               oncommand="openCertManager();" 
>               id="openCertManagerButton"
>               accesskey="&managecerts.accesskey;"
>+              onsyncfrompreference="return this.pane.enableButton(this);"
onsyncfrompreference is not needed, see earlier.
>+              preference="security.disable_button.openCertManager"
>+              preference-editable="true"/>
Shouldn't need this attribute either.

>       <button label="&managedevices.button;"
>               oncommand="openDeviceManager();"
>               id="openDeviceManagerButton"
>               accesskey="&managedevices.accesskey;"
>+              onsyncfrompreference="return this.pane.enableButton(this);"
onsyncfrompreference is not needed, see earlier.
>+              preference="security.disable_button.openDeviceManager"
>+              preference-editable="true"/>
Shouldn't need this attribute either.

r- for the moment.
Attachment #336823 - Flags: review?(iann_bugzilla) → review-
Blocks: 445014
>>+function Startup()
>No Startup function needed as onsync is not need here, see later.
>>+function enableButton(button)
>Not needed, see later.
>In the new pref panel world disable_button prefs disable buttons when they are
>locked, the value of the pref makes no difference. So inverted attribute is not
>needed.
Fixed.

>> function openCertManager()
>Nit: Capital letter at the start of a function name.
Fixed.
>> function openDeviceManager()
>Nit: Capital letter at the start of a function name.
Fixed.

>Nit: value as first attribute please.
Fixed.
>Nit: value as first attribute please.
Fixed.

>>+              onsyncfrompreference="return this.pane.enableButton(this);"
>onsyncfrompreference is not needed, see earlier.
>>+              preference="security.disable_button.openCertManager"
>>+              preference-editable="true"/>
>Shouldn't need this attribute either.
Fixed and Fixed.
Attachment #336823 - Attachment is obsolete: true
Attachment #337189 - Flags: superreview?(neil)
Attachment #337189 - Flags: review?(iann_bugzilla)
Attachment #337189 - Flags: superreview?(neil) → superreview+
Comment on attachment 337189 [details] [diff] [review]
Patch v 2.0 Convert pref-ssl.xul and pref-certs.xul to prefpanes

I would remove the two "<!-- Prefs -->" lines from pref-ssl.xul as I don't think they have any meaning/reason to be in there anymore (or before that to be honest).
r=me with that change
Attachment #337189 - Flags: review?(iann_bugzilla) → review+
Fixed review nits. Carrying forward r+=iann_bugzilla sr+=neil
Attachment #337189 - Attachment is obsolete: true
Attachment #337379 - Flags: superreview+
Attachment #337379 - Flags: review+
Keywords: checkin-needed
Comment on attachment 337379 [details] [diff] [review]
Patch v 2.1 Ready for check-in. (Checkin: Comment 12)

http://hg.mozilla.org/comm-central/rev/b3ca3c955a12
Attachment #337379 - Attachment description: Patch v 2.1 Ready for check-in. [Comment 11] → Patch v 2.1 Ready for check-in. (Checkin: Comment 12)
Status: NEW → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.