Closed Bug 44505 Opened 20 years ago Closed 20 years ago

cell padding depends from table nesting for table-layout:fixed

Categories

(Core :: Layout: Tables, defect, P3)

Product:
Core
Component:
Layout: Tables
Platform:
x86
Windows NT
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9

People

(Reporter: make, Assigned: karnaze)

Details

(Keywords: css1, testcase)

Attachments

(7 files)

testcase for 44505 and 44506
3.50 KB, text/html
Details
Corrected testcase
3.50 KB, text/html
Details
reduced testcase
1.98 KB, text/html
Details
patch
1.38 KB, patch
Details | Diff | Splinter Review
testcase
2.27 KB, text/html
Details
testcase with image
443 bytes, text/html
Details
revised patch (new style handling)
1.54 KB, patch
Details | Diff | Splinter Review 
From Bugzilla Helper:
User-Agent: Mozilla/4.73 [en] (WinNT; U)
BuildID:    2000070320

Tables using the fixed layout algorithm (table-layout:fixed) seem to ignore the 
padding on all cells in a row (except on the first one).

Reproducible: Always
Steps to Reproduce:
1. Create a table with one row and some cells
2. Set css widths and paddings for each cell
3. Load the table

Actual Results:  The paddding is ignored for all cells except the first one.

Expected Results:  The padding should be applied to all cells where it has been 
specified.							

padding works fine when used with other table layout algorithms.
Keywords: css1
Bug seems to be related to nested tables. Couldn't reproduce with plain tables.
Keywords: testcase
Attached file Corrected testcase —
Attached file reduced testcase — 
The padding seems to depend on the table nesting (see reduced testcase).
Confirming the bug. Changing summary
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: padding is ignored on all but the first cell if table-layout:fixed → cell padding depends from table nesting for table-layout:fixed
Status: NEW → ASSIGNED
Target Milestone: --- → M19
QA Contact: desale → chrisd
Attached patch patch — — Splinter Review
Attached file testcase —
Attached file testcase with image — 
Finally, I managed to verify that the patch does not not break the table
regression tests. (It would be also very difficult, as we do not have any
testcase in the regression tests that tests for clipping ... this is a ping to
the QA engineer). The patch enables the overflow:hidden from CSS2 for table
cells. I think with the correct handling of the padding we outperfom with this
patch IE5. They have overflow:hidden for the fixed layout (you cannot make it
visible) and they do not handle padding correctly. This patch does not enable
overflow:scroll and overflow:auto, but I think it improves anyway our CSS2
compliance.
Keywords: patch, review
sr=attinasi - the patch looks fine. Can we add the testcase to the table
regression tests? Generally, Chris K. adds them and not a QA person. As you
mentioned, Bernd, we need a testcase in the regression suite to catch this case
and none currently exist. Thanks.


> Generally, Chris K. adds them and not a QA person.

But should this prevent chrisd@netscape.com to write something comparable to
marvin for CSS2 table stuff, I think we need it desperately.

The testcase renders now fine. fix checked in
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Please notice that the even the corrected testcase has an omitted padding
attribute for the third cell. 
	<TD nowrap style="text-align:left; 0px 5px 0px 5px; white-space:nowrap;
width:45px">45px</TD>
Target Milestone: --- → mozilla0.9
QA contact update
QA Contact: chrisd → amar
 The attached testcase renders fine
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.