445104 - ssl redirects come with a 200 OK HTTP code on mod_perl

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Max Kanat-Alexander]

Today I logged into my "ssl: authenticated sessions" mod_perl tip installation, and I got a 200 OK with a redirect message, instead of a 302. This looks like a regression from the recent ssl-redirect fix.

Comment 1

[Max Kanat-Alexander]

I can only reproduce this under mod_perl--that might indicate a bug in CGI.pm.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

Okay, this fixes it. The problem is under mod_perl, CGI.pm sends headers by calling a method on the mod_perl Request object. That *queues* headers to be sent. But then when we print a newline, that forces the *default* headers to be sent immediately, which are of course 200 OK headers (it was also pretty suspicious since they had an ISO-8859-1 charset instead of a UTF-8 one).

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 330128 [details] [diff] [review]
v1

Tested on our devel system and works as expect. 
r=dkl

Comment 4

[Frédéric Buclin]

Please check in this patch. :)

Comment 5

[Max Kanat-Alexander]

tip:

Checking in Bugzilla/CGI.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/CGI.pm,v  <--  CGI.pm
new revision: 1.38; previous revision: 1.37
done

3.2 branch:

Checking in Bugzilla/CGI.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/CGI.pm,v  <--  CGI.pm
new revision: 1.36.2.2; previous revision: 1.36.2.1
done

Comment 6

[David Lawrence [:dkl]]

Had to back out this patch in addition to the main SSL redirect patch as was causing regression. For more details please see bug 428659.

Comment 7

[David Lawrence [:dkl]]

Fixed for this was checked in with the patch in bug 428659. Closing.

Dave