44512 - args for opendialog destroyed if one var is 0

Status: NEW

(Core :: XUL, defect, P3)

Description

[Ben Bucksch (:BenB)]

Reproduce:
1. Take patch from bug 38433.
2. Send yourself a msg containing colored text.

Actual and expected result:
- A dialog comes up, telling that you used formatting that cannot be converted
to plaintext.

Reproduce:
3. Change const |AskUser| to |0| in mailnews/compose/public/nsIMsgCompose.idl
4. Repeat step 2.

Actual result:
- A dialog comes up, but without a statement about the ability to convert the
msg.

Expected result:
- Same as after step 2.

Additional comments:
In mailnews/compose/resources/nsMsgComposeCommands.js, |AskUser| is assigned to
|results.action|, and |results| is then passed as args param to |opendialog|.
|results.action| can be dumped in nsMsgComposeCommands.js, but |param.action|
(which should be the same var) does not exist anymore in
mailnews/compose/resources/askSendFormat.js.

Comment 1

[Ben Bucksch (:BenB)]

Step 3a. Recompile mailnews/compose.

Comment 2

[Mike Pinkerton (not reading bugmail)]

dan?

Comment 3

[Peter Trudelle]

->Future

Comment 4

[Hixie (not reading bugmail)]

Is this still relevant?

Comment 5

[Thomas D. (:thomas8)]

(In reply to Hixie (not reading bugmail) from comment #4)

Is this still relevant?

Ben?

Comment 6

[Ben Bucksch (:BenB)]

I don't know. This was an API bug in a the XU dialog feature. You'd have to write specific source code to test whether that still exists. The reproduction cites Thunderbird, but the bug was in the general XUL dialog API.