445167 - Remove "comments only" <msgHdrViewAddresses.js>

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Serge Gautherie (:sgautherie)]

(I can't add the dependence on bug 40516...)

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1-TB) Remove uses [Checkin: Comment 4]

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-SM) Remove uses [Checkin: Comment 4]

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 329493 [details] [diff] [review]
(Av1-TB) Remove uses
[Checkin: Comment 4]

Dan's busy this week, so I'm going to grab this and say its ok.

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #1)
> Created an attachment (id=329493) [details]
> (Av1-TB) Remove uses
> 

Checking in mail/base/content/msgHdrViewOverlay.xul;
/cvsroot/mozilla/mail/base/content/msgHdrViewOverlay.xul,v  <--  msgHdrViewOverlay.xul
new revision: 1.30; previous revision: 1.29
done
Checking in mail/base/jar.mn;
/cvsroot/mozilla/mail/base/jar.mn,v  <--  jar.mn
new revision: 1.119; previous revision: 1.118
done

(In reply to comment #2)
> Created an attachment (id=329496) [details]
> (Bv1-SM) Remove uses
> 

Checking in mailnews/base/resources/content/msgHdrViewOverlay.xul;
/cvsroot/mozilla/mailnews/base/resources/content/msgHdrViewOverlay.xul,v  <--  msgHdrViewOverlay.xul
new revision: 1.74; previous revision: 1.73
done
Checking in mailnews/jar.mn;
/cvsroot/mozilla/mailnews/jar.mn,v  <--  jar.mn
new revision: 1.135; previous revision: 1.134
done


Strictly speaking, the SM patch should have had sr as well. However given the simplicity in this case and the fact it is really just SM only UI, I've checked it in anyway.

Please get sr in future for all mailnews/ patches until such a time as the review policy is changed (if ever).

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> Strictly speaking, the SM patch should have had sr as well.

I thought the (asked) review from dmose would "rs" this...

Comment 6

[Mark Banner (:standard8)]

(In reply to comment #5)
> (In reply to comment #4)
> > Strictly speaking, the SM patch should have had sr as well.
> 
> I thought the (asked) review from dmose would "rs" this...
> 
No - you asked for review from dmose on the TB patch, plus you should be explicit if that is what you are doing.

Comment 7

[Mark Banner (:standard8)]

Removing mailnews/base/resources/content/msgHdrViewAddresses.js;
/cvsroot/mozilla/mailnews/base/resources/content/msgHdrViewAddresses.js,v  <--  msgHdrViewAddresses.js
new revision: delete; previous revision: 1.8
done