445182 - Weave's new "Syncing with Weave" dialog is too short

Status: RESOLVED FIXED

(Cloud Services :: General, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot 1: during sync process

The "Syncing with Weave" dialog (which appears when I choose "Sync Now" or when I quit Firefox) is too short for its content on Linux.

See screenshots.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot 2: sync complete

Note that the "Cancel" button is cut off at the lower-left corner of the dialog in both of these screenshots.

Comment 2

[Daniel Holbert [:dholbert]]

VERSION INFO:
Ubuntu Linux 8.04
Firefox 3.0.0
Weave 0.2.4

Comment 3

[bomfog]

Windows also. OS -> ALL

Comment 5

[Fritz]

Attachment: Glitch in Windows

Comment 6

[Dan Mills [:thunder]]

I believe OSX is the only one that is not affected.

Comment 7

[u317110]

I can confirm this is not an issue in OS X

Comment 8

[Daniel Holbert [:dholbert]]

Attachment: screenshot 4: before status message appears (*not* too short yet)

This screenshot shows that the dialog's height is fine *before* any status messages appear.

Apparently the issue is that when the status messages appear, they push the "Cancel" button down & out of view.

Comment 9

[Petr Klíma]

I can confirm it on Ubuntu 8.O4 x86

This workaround solved this problem, it "presize" the dialog, so when message appear it does not "push button away. 
========================== patch ==================================
diff -r 853168d184ad chrome/content/status.css
--- a/chrome/content/status.css Thu Aug 14 17:23:11 2008 -0700
+++ b/chrome/content/status.css Fri Aug 15 16:04:39 2008 +0200
@@ -1,5 +1,6 @@
 #sync-status-dialog {
   width: 300px;
+  height: 150px;
 }
 
 #statusTitleIcon {
========================== patch end ==============================

Comment 10

[Dan Mills [:thunder]]

Does the patch from comment #9 work on other platforms?  What about other gtk+ themes on Linux?

Comment 11

[Petr Klíma]

(In reply to comment #10)
> Does the patch from comment #9 work on other platforms?  What about other gtk+
> themes on Linux?
> 

Linux Ubuntu 8.04.01
- it is OK with one exception, an weird theme with 8px border around elemets (buttons, progress bars ...)

Windows XP SP3
- common theme OK

Mac OS X  
- I have no access to

Comment 12

[Petr Klíma]

I have a better solution.

This makes dialog render with "nonempty" labels so it reserves space for them.

The window size is counted with respect of labels size.

=================== patch ========================================
diff -r 853168d184ad chrome/content/status.xul
--- a/chrome/content/status.xul Thu Aug 14 17:23:11 2008 -0700
+++ b/chrome/content/status.xul Tue Aug 19 07:20:00 2008 +0200
@@ -32,8 +32,11 @@
       <hbox align="center" id="statusBox">
         <image id="statusIcon"/>
         <vbox>
-          <label id="statusEngine"/>
-          <label id="statusText"/>
+          <!-- Empty values should resolve bugzilla record on
+               https://bugzilla.mozilla.org/show_bug.cgi?id=445182
+           -->  
+          <label id="statusEngine" value=""/>
+          <label id="statusText" value=""/>
         </vbox>
       </hbox>
   </vbox>
=================== patch end =======================================

Tested on

Linux Ubuntu 8.04.01
- it is OK with one exception, an weird theme with 8px border around elemets
(buttons, progress bars ...) and really big font.
 In that case is, the dialog has correct height but width is short (some labels are long enought to stretch <hbox id="statusBox"> out of dialog window border.

Windows XP SP3
- common theme OK

Mac OS X  
- I have no access to

Comment 13

[Dan Mills [:thunder]]

I've committed the patch from comment #12 (though I modified the comment a bit).  Thanks very much!

changeset:   1077:131e8bb7b63f
tag:         tip
user:        Dan Mills <[e-mail]>
date:        Tue Aug 19 13:41:14 2008 -0700
summary:     Bug 445182: status window cuts off button because it is too short.  Based on patch by Petr Klíma <[e-mail]>