Closed Bug 445199 Opened 16 years ago Closed 16 years ago

GetMsgTextFromStream should return an AUTF8String

Categories

(MailNews Core :: Backend, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.1a1

People

(Reporter: rain1, Assigned: rain1)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
GetMsgTextFromStream in nsMsgDBFolder returns a UTF-8 string, but the idl declaration says it returns an 8-bit ACString.
Attachment #329504 - Flags: superreview?(bienvenu)
Attachment #329504 - Flags: review?(bienvenu)
Comment on attachment 329504 [details] [diff] [review]
patch

I don't know if you need to rev the uuid or not for this kind of change.  I guess this interface has had its uid revved since 2.0 enough that it's probably not an issue.
Attachment #329504 - Flags: superreview?(bienvenu)
Attachment #329504 - Flags: superreview+
Attachment #329504 - Flags: review?(bienvenu)
Attachment #329504 - Flags: review+
Attached patch changed UUID tooSplinter Review
just to be safe.

One user, nsMsgDBFolder::GetMsgPreviewTextFromStream, thinks it's an 8bit nsACString, but an escape seems to happen in setStringProperty, preserving the bytes. getStringProperty returns escaped text, and that can be later unescaped, so we're all right there.
Attachment #329504 - Attachment is obsolete: true
Attachment #329533 - Flags: superreview+
Attachment #329533 - Flags: review+
Keywords: checkin-needed
Checking in mailnews/base/public/nsIMsgFolder.idl;
/cvsroot/mozilla/mailnews/base/public/nsIMsgFolder.idl,v  <--  nsIMsgFolder.idl
new revision: 1.200; previous revision: 1.199
done
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.1a1
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: