GetMsgTextFromStream should return an AUTF8String

RESOLVED FIXED in mozilla1.9.1a1

Status

MailNews Core
Backend
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: sid0, Assigned: sid0)

Tracking

(Blocks: 1 bug)

Trunk
mozilla1.9.1a1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Created attachment 329504 [details] [diff] [review]
patch

GetMsgTextFromStream in nsMsgDBFolder returns a UTF-8 string, but the idl declaration says it returns an 8-bit ACString.
Attachment #329504 - Flags: superreview?(bienvenu)
Attachment #329504 - Flags: review?(bienvenu)

Comment 1

10 years ago
Comment on attachment 329504 [details] [diff] [review]
patch

I don't know if you need to rev the uuid or not for this kind of change.  I guess this interface has had its uid revved since 2.0 enough that it's probably not an issue.
Attachment #329504 - Flags: superreview?(bienvenu)
Attachment #329504 - Flags: superreview+
Attachment #329504 - Flags: review?(bienvenu)
Attachment #329504 - Flags: review+
(Assignee)

Comment 2

10 years ago
Created attachment 329533 [details] [diff] [review]
changed UUID too

just to be safe.

One user, nsMsgDBFolder::GetMsgPreviewTextFromStream, thinks it's an 8bit nsACString, but an escape seems to happen in setStringProperty, preserving the bytes. getStringProperty returns escaped text, and that can be later unescaped, so we're all right there.
Attachment #329504 - Attachment is obsolete: true
Attachment #329533 - Flags: superreview+
Attachment #329533 - Flags: review+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Checking in mailnews/base/public/nsIMsgFolder.idl;
/cvsroot/mozilla/mailnews/base/public/nsIMsgFolder.idl,v  <--  nsIMsgFolder.idl
new revision: 1.200; previous revision: 1.199
done
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.1a1
(Assignee)

Updated

10 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.