Closed
Bug 445199
Opened 16 years ago
Closed 16 years ago
GetMsgTextFromStream should return an AUTF8String
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.1a1
People
(Reporter: rain1, Assigned: rain1)
References
Details
Attachments
(1 file, 1 obsolete file)
1.92 KB,
patch
|
rain1
:
review+
rain1
:
superreview+
|
Details | Diff | Splinter Review |
GetMsgTextFromStream in nsMsgDBFolder returns a UTF-8 string, but the idl declaration says it returns an 8-bit ACString.
Attachment #329504 -
Flags: superreview?(bienvenu)
Attachment #329504 -
Flags: review?(bienvenu)
Comment 1•16 years ago
|
||
Comment on attachment 329504 [details] [diff] [review] patch I don't know if you need to rev the uuid or not for this kind of change. I guess this interface has had its uid revved since 2.0 enough that it's probably not an issue.
Attachment #329504 -
Flags: superreview?(bienvenu)
Attachment #329504 -
Flags: superreview+
Attachment #329504 -
Flags: review?(bienvenu)
Attachment #329504 -
Flags: review+
Assignee | ||
Comment 2•16 years ago
|
||
just to be safe. One user, nsMsgDBFolder::GetMsgPreviewTextFromStream, thinks it's an 8bit nsACString, but an escape seems to happen in setStringProperty, preserving the bytes. getStringProperty returns escaped text, and that can be later unescaped, so we're all right there.
Attachment #329504 -
Attachment is obsolete: true
Attachment #329533 -
Flags: superreview+
Attachment #329533 -
Flags: review+
Assignee | ||
Updated•16 years ago
|
Keywords: checkin-needed
Comment 3•16 years ago
|
||
Checking in mailnews/base/public/nsIMsgFolder.idl; /cvsroot/mozilla/mailnews/base/public/nsIMsgFolder.idl,v <-- nsIMsgFolder.idl new revision: 1.200; previous revision: 1.199 done
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.1a1
Assignee | ||
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•