Closed
Bug 445268
Opened 17 years ago
Closed 17 years ago
gfxRect is used uninitialized in nsSVGFilterInstance::ComputeFilterPrimitiveSubregion
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: roc, Assigned: roc)
References
Details
Attachments
(1 file)
|
1.22 KB,
patch
|
longsonr
:
review+
MatsPalmgren_bugz
:
superreview+
|
Details | Diff | Splinter Review |
See attached patch.
Attachment #329606 -
Flags: superreview?(mats.palmgren)
Attachment #329606 -
Flags: review?(longsonr)
|
Assignee | |
Comment 1•17 years ago
|
||
(Unlike nsRect, gfxRect doesn't initialize itself to zeroes).
|
||
Comment 2•17 years ago
|
||
Comment on attachment 329606 [details] [diff] [review]
fix
Add a space after each comma please.
Attachment #329606 -
Flags: review?(longsonr) → review+
|
||
Comment 3•17 years ago
|
||
Comment on attachment 329606 [details] [diff] [review]
fix
sr=mats
Attachment #329606 -
Flags: superreview?(mats.palmgren) → superreview+
|
|
Assignee | |
Comment 4•17 years ago
|
||
Pushed d0a71ca639ee.
Dao, let me know if this does or does not fix the problem on Windows...
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Comment 5•17 years ago
|
||
Works as expected.
I'm surprised that this wasn't caught by a reftest.
|
|
Assignee | |
Comment 6•17 years ago
|
||
Great. Yeah, I'm surprised too since we do have drop-shadow reftests. Uninitialized data bugs are just too random.
|
|
Assignee | |
Comment 7•17 years ago
|
||
Actually it's possible that the random failure of feGaussianBlur-3.html on Linux (which I disabled) was caused by this bug. I should try reenabling it.
You need to log in
before you can comment on or make changes to this bug.
Description
•