445330 - document.loaded XML documents fire onload before DOMContentLoaded

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: testcase

The problem is that XMLDocument::EndLoad fires onload sync. before we even dispatch the event to fire DOMContentLoaded.

See http://hg.mozilla.org/mozilla-central/index.cgi/annotate/6db0b5d30af1/content/xml/document/src/nsXMLDocument.cpp#l539

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Oh, the expected output of the testcase is:

...DOMContentLoaded called... ...onload called...

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Hmm, I took this too fast :) - making load event dispatch asynchronous
(so that it happens after DOMContentLoaded) breaks many XBL testcases.
Perhaps I should take another approach, dispatch DOMContentLoaded synchronously
right before load event.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Sync DOMContentLoaded

Not sure we want this though :/

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 329719 [details] [diff] [review]
Sync DOMContentLoaded

Bz, IIRC you changed DOMContentLoaded to be async. This patch shouldn't cause any new problems since load event is anyway synchronous for data and XBL documents.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 329719 [details] [diff] [review]
Sync DOMContentLoaded

Makes sense.