If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

adding imap saved search creates unneeded .sbd

RESOLVED FIXED in mozilla1.9.1a1

Status

MailNews Core
Search
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

Trunk
mozilla1.9.1a1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.14 KB, patch
neil@parkwaycc.co.uk
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
When we create an imap saved search, it creates a .sbd folder for that saved search - I think it really means to be creating a .sbd folder for the parent folder.
(Assignee)

Comment 1

9 years ago
Created attachment 329693 [details] [diff] [review]
proposed fix 

I think this is what the code meant to do - create a .sbd folder for the parent folder.

I'm still working on some other isses having to do with escaping folder names. I want to make sure everything is fixed before getting reviews, in case the patches are dependent on each other.
(Assignee)

Comment 2

9 years ago
Comment on attachment 329693 [details] [diff] [review]
proposed fix 

turned out the %20 names was unrelated to this issue, so this fix should be sufficient for this issue.
Attachment #329693 - Flags: superreview?(neil)
Attachment #329693 - Flags: review?(neil)

Comment 3

9 years ago
Comment on attachment 329693 [details] [diff] [review]
proposed fix 

>+  PRBool isServer;
>+  rv = GetIsServer(&isServer);
>+  NS_ENSURE_SUCCESS(rv, rv);
>+
>+  if (!isServer)
>+  {
>+  }
I don't think this is necessary - the code checks whether the directory name exists with and without a .sbd before creating it with a .sbd, and (at least in my tests) the server folder is always created when the account is created.

It's good to be getting rid of that unsafe-looking static cast :-)
Attachment #329693 - Flags: superreview?(neil)
Attachment #329693 - Flags: superreview+
Attachment #329693 - Flags: review?(neil)
Attachment #329693 - Flags: review+
(Assignee)

Comment 4

9 years ago
I think you're right - I've [gladly] gotten rid of the isServer check locally.
(Assignee)

Updated

9 years ago
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Updated

9 years ago
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → mozilla1.9.1a1
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.